Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modify value #132

Merged
merged 6 commits into from
Nov 12, 2018
Merged

Conversation

dxinteractive
Copy link
Collaborator

@dxinteractive dxinteractive commented Oct 26, 2018

dataparcels

  • BREAKING CHANGE renamed Parcel.modifyChange() to Parcel.modifyChangeBatch()
  • BREAKING CHANGE modifyValue and modifyChangeValue are now safe Make modifyValue and modifyChangeValue unable to break yourself #131
    • modifyValue()'s updater can not return a value that has children unless it is unchanged by the updater or is empty
    • modifyChangeValue()'s updater is passed a value that has children, it cannot return a value that has children unless it is unchanged by the updater
    • this is to ensure that values are not disassociated with their keys, and to ensure cannot be set on lower parcels that will be lost when changes come back up. The primary use case for these functions are for use with primitives, or setting undefined values to an empty parent data type.
  • BREAKING CHANGE removed Parcel.dangerouslyReplace()
  • fix: add function hashers to modify methods Add function hashers to modify functions ids #125

@dxinteractive dxinteractive changed the base branch from master to release/superior-snake October 26, 2018 01:37
@dxinteractive dxinteractive merged commit 9e17b9c into release/superior-snake Nov 12, 2018
@dxinteractive dxinteractive deleted the feature/modify-value branch November 12, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants