Feature/hooks reorganised #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxinteractive
force-pushed
the
feature/hooks-reorganised
branch
from
aa3a813 to
ca1dce7
Compare
dxinteractive
force-pushed
the
feature/hooks-reorganised
branch
from
ca1dce7 to
368bd7c
Compare
dxinteractive
force-pushed
the
feature/hooks-reorganised
branch
from
5faa66e to
05f784d
Compare
- now exported full lowercase (validation, not Validation) - now returns a parceldata updater directly, instead of an object with a modifyBeforeUpdate function on it - now falsifies any meta._submit keys. this will be used by useParcelBuffer prevent submission of invalid forms
dxinteractive
force-pushed
the
feature/hooks-reorganised
branch
2 times, most recently
from
5605c2a to
aab5c08
Compare
parcels know of each others existence via the registry, which each parcel adds itself too. this is so even parcels that havend re-rendered in forever can have a reference to the newest version of their parent parcel. boundary splitting is making sure that when a parcel boundary is used, that they each have their own registry, so parel boundaries dont accidentally share updates telepathically between each other. right now this is a tad broken with hooks. ill fix it soon, but the frequency that we'll hit this (i.e. never) means id rather uncover this logical hole for a bit to get hooks out
rather than an object with a modifyBeforeUpdate function on it it can also now block submit actions (where submit actions use meta._submit like upcoming useParcelBuffer does), and also not show errors until a submit attempt has been made
a few breaking changes here, will be documented in the pr
dxinteractive
force-pushed
the
feature/hooks-reorganised
branch
from
ff9c533 to
a6c273c
Compare
allanhortle
approved these changes
May 30, 2019
|
|
||
| const internalBuffer = useParcelBufferInternalBuffer({ | ||
| onReset: () => setOuterParcel(null), | ||
| // ^ resets by ecreating innerParcel from outerParcel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #204 #215 #205 #213
Hooks are finally here!
dataparcels
Validationrenamed tovalidationto match all other function exports{modifyBeforeUpdate: Function}meta.invalidListuseParcelFormanduseParcelBufferreact-dataparcels
useParcelStatehook (similar to ParcelHoc)useParcelBufferhook (similar to ParcelBoundaryHoc)useParcelFormhook (new hook to provide pre-build form-like behaviours)useParcelBufferdebugBufferis gonedebugParcelis goneonCancelis goneonReleaseis gonemodifyBeforeUpdateis deprecated, superseded bybeforeChange, now accepts non-array functionsParcelBufferControl, not aParcelBoundaryControlParcelHocandParcelBoundaryHocare deprecateddataparcels-docs
dcme-gatsbyDocs: add left and right navs #213