Feature/on submit #229
Merged
Feature/on submit #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also onChangeUseResult > onSubmitUseResult and onChangeStatus > submitStatus The reason is because the action is being referred to as submit everywhere else. Even the function that triggers the submit is called "submit". This was called onChange, because according to the internal useParcelState hook it is just a change, but the name should really reflect how its used
dancoates
approved these changes
Jun 21, 2019
allanhortle
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-dataparcels
useParcelForm onChangeis nowuseParcelForm onSubmituseParcelForm onChangeUseResultis nowuseParcelForm onSubmitUseResultuseParcelForm's returnedonChangeStatusis nowsubmitStatusThe reason is because the action is being referred to as submit
everywhere else. Even the function that triggers the submit is
called "submit". This was called onChange, because from the point of view of
the internal useParcelState hook it is just a "change", and that variable name just flew out the window but the name should really reflect how its used