Fix linter issues

.golangci.yml

@@ -106,6 +106,10 @@ issues:
     - path: codegen/testserver/.*/resolver\.go
       linters:
         - gocritic
+    # The interfaces are autogenerated and don't conform to the paramTypeCombine rule
+    - path: _examples/federation/products/graph/entity.resolvers.go
+      linters:
+        - gocritic
     # Disable revive.use-any for backwards compatibility
     - path: graphql/map.go
       text: "use-any: since GO 1.18 'interface{}' can be replaced by 'any'"

_examples/federation/reviews/graph/resolver.go

@@ -11,7 +11,7 @@ import (
 
 type Resolver struct{}
 
-func (r *entityResolver) FindProductByManufacturerIDAndID(ctx context.Context, manufacturerID string, id string) (*model.Product, error) {
+func (r *entityResolver) FindProductByManufacturerIDAndID(ctx context.Context, manufacturerID, id string) (*model.Product, error) {
 	var productReviews []*model.Review
 
 	for _, review := range reviews {

plugin/federation/federation.go

@@ -640,7 +640,7 @@ func (f *Federation) generateExplicitRequires(
 func buildResolverSDL(
 	resolver *EntityResolver,
 	multi bool,
-) (resolverSDL string, entityResolverInputSDL string) {
+) (resolverSDL, entityResolverInputSDL string) {
 	if multi {
 		entityResolverInputSDL = buildEntityResolverInputDefinitionSDL(resolver)
 		resolverSDL := fmt.Sprintf("\t%s(reps: [%s]!): [%s]", resolver.ResolverName, resolver.InputTypeName, resolver.ReturnTypeName)

plugin/federation/federation_test.go

@@ -21,7 +21,7 @@ func TestNew(t *testing.T) {
 			},
 		}
 		plugin, err := New(1, cfg)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.NotNil(t, plugin)
 	})
 
@@ -36,7 +36,7 @@ func TestNew(t *testing.T) {
 			CallArgumentDirectivesWithNull: true,
 		}
 		plugin, err := New(1, cfg)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.NotNil(t, plugin)
 	})
 
@@ -51,7 +51,7 @@ func TestNew(t *testing.T) {
 			CallArgumentDirectivesWithNull: true,
 		}
 		plugin, err := New(1, cfg)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Nil(t, plugin)
 	})
 
@@ -66,7 +66,7 @@ func TestNew(t *testing.T) {
 			CallArgumentDirectivesWithNull: false,
 		}
 		plugin, err := New(1, cfg)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Nil(t, plugin)
 	})
 
@@ -82,7 +82,7 @@ func TestNew(t *testing.T) {
 		}
 
 		plugin, err := New(1, cfg)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Nil(t, plugin)
 	})
 }