fix a TODO about named boolean under _examples/scalars

99designs · Dec 24, 2022 · b8eebbd · b8eebbd
1 parent 99c63a0
commit b8eebbd
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 47 deletions.
diff --git a/_examples/scalars/.gqlgen.yml b/_examples/scalars/.gqlgen.yml
@@ -14,7 +14,5 @@ models:
     model: github.com/99designs/gqlgen/_examples/scalars/model.ID
   Tier:
     model: github.com/99designs/gqlgen/_examples/scalars/model.Tier
-  Banned:
-    model: github.com/99designs/gqlgen/_examples/scalars/model.Banned
   DarkMode:
     model: github.com/99designs/gqlgen/_examples/scalars/model.Preferences
diff --git a/_examples/scalars/generated.go b/_examples/scalars/generated.go
diff --git a/_examples/scalars/model/model.go b/_examples/scalars/model/model.go
@@ -14,27 +14,6 @@ import (
 
 type Banned bool
 
-func (b Banned) MarshalGQL(w io.Writer) {
-	if b {
-		w.Write([]byte("true"))
-	} else {
-		w.Write([]byte("false"))
-	}
-}
-
-func (b *Banned) UnmarshalGQL(v interface{}) error {
-	switch v := v.(type) {
-	case string:
-		*b = strings.ToLower(v) == "true"
-		return nil
-	case bool:
-		*b = Banned(v)
-		return nil
-	default:
-		return fmt.Errorf("%T is not a bool", v)
-	}
-}
-
 type User struct {
 	ID       external.ObjectID
 	Name     string

diff --git a/_examples/scalars/schema.graphql b/_examples/scalars/schema.graphql
@@ -11,7 +11,7 @@ type User {
     modified: Timestamp
     valPrefs: DarkMode
     ptrPrefs: DarkMode
-    isBanned: Banned!
+    isBanned: Boolean!
     primitiveResolver: String!
     customResolver: Point!
     address: Address
@@ -27,7 +27,7 @@ type Address {
 input SearchArgs {
     location: Point
     createdAfter: Timestamp
-    isBanned: Banned # TODO: This can be a Boolean again once multiple backing types are allowed
+    isBanned: Boolean
 }
 
 enum Tier {
@@ -38,5 +38,4 @@ enum Tier {
 
 scalar Timestamp
 scalar Point
-scalar Banned
 scalar DarkMode