fix: codegen will _ the fieldset parameter if its not needed (#3006)

* fix: codegen will _ the fieldset parameter if its not needed * update generated examples
99designs · Apr 13, 2024 · c17a4b6 · c17a4b6
1 parent 0b0f659
commit c17a4b6
Show file tree

Hide file tree

Showing 18 changed files with 140 additions and 140 deletions.
diff --git a/_examples/chat/generated.go b/_examples/chat/generated.go
diff --git a/_examples/dataloader/generated.go b/_examples/dataloader/generated.go
diff --git a/_examples/enum/api/exec.go b/_examples/enum/api/exec.go
diff --git a/_examples/federation/accounts/graph/generated.go b/_examples/federation/accounts/graph/generated.go
diff --git a/_examples/federation/products/graph/generated.go b/_examples/federation/products/graph/generated.go
diff --git a/_examples/federation/reviews/graph/generated.go b/_examples/federation/reviews/graph/generated.go
diff --git a/_examples/scalars/generated.go b/_examples/scalars/generated.go
diff --git a/_examples/selection/generated.go b/_examples/selection/generated.go
diff --git a/_examples/starwars/generated/exec.go b/_examples/starwars/generated/exec.go
diff --git a/_examples/todo/generated.go b/_examples/todo/generated.go
diff --git a/_examples/type-system-extension/generated.go b/_examples/type-system-extension/generated.go
diff --git a/codegen/object.gotpl b/codegen/object.gotpl
@@ -48,7 +48,7 @@ func (ec *executionContext) _{{$object.Name}}(ctx context.Context, sel ast.Selec
  {{- if $field.IsConcurrent }}
  field := field
 
- innerFunc := func(ctx context.Context, fs *graphql.FieldSet) (res graphql.Marshaler) {
+ innerFunc := func(ctx context.Context, {{ if $field.TypeReference.GQL.NonNull }}fs{{ else }}_{{ end }} *graphql.FieldSet) (res graphql.Marshaler) {
  defer func() {
  if r := recover(); r != nil {
  ec.Error(ctx, ec.Recover(ctx, r))