Make sure there's a Query node before trying to add a field to it. #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federation adds some queries to the schema. There already existed code to insert a Query node if none existed previously. But that code was only put on addEntityToSchema(), and not the other place we update the query, addServiceToSchema(). Almost always the old code was good enough, since we call addEntityToSchema() before addServiceToSchema(). But there's on exception: when the schema has no `@key`. In that case we only call addServiceToSchema(), so we need to do the query-existence check there too.
csilvers
force-pushed
the
query-exists
branch
from
b4f2f6c to
9f2a624
Compare
|
@marwan-at-work -- this is appropriate for you to review I think. This fixes a bug from my last PR (that allowed code to work without a |
|
(Also, I can't figure out a good way to test MutateSchema -- if you know of one, let me know!) |
|
Sweet, good to see this getting some polish before 0.11 👍 |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Make sure there's a Query node before trying to add a field to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Federation adds some queries to the schema. There already existed
code to insert a Query node if none existed previously. But that code
was only put on addEntityToSchema(), and not the other place we update
the query, addServiceToSchema().
Almost always the old code was good enough, since we call
addEntityToSchema() before addServiceToSchema(). But there's on
exception: when the schema has no
@key. In that case we only calladdServiceToSchema(), so we need to do the query-existence check there
too.
Describe your PR and link to any relevant issues.
I have: