-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suppress golint messages #1054
suppress golint messages #1054
Conversation
func (r *Resolver) Subscription() SubscriptionResolver { return &subscriptionResolver{r} } | ||
func (r *Resolver) User() UserResolver { return &userResolver{r} } | ||
|
||
// Panics returns PanicsResolver implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤢
If you can build them out of a template then its not giving any context or new information to the reader. This is just pure noise.
can we tell golint to ignore these semi-generated files instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, We can't... 😿 I agreed about its noisy comment. but I need suppress golint error messages...
golint can't configure that same as gofmt.
golint only have -min_confidence
options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highly recommend https://github.com/golangci/golangci-lint.
It will speed up your builds, provide consistent formatting and give you the ability to skip linters consistently on a line/function/file basis based on consistent comments - https://github.com/golangci/golangci-lint#false-positives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I know... but Our project can't it immediately.
and, I don't think gqlgen should not limit what tools users should use.
this change is little bit noisy, but useful for golint user I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( Okay
thanks! 👍 🙇 |
suppress golint messages
I tried new resolver layout. It's pretty nice!
In my app, golint emit messages to resolver files.
I wanna suppress it.
gqlgen maintenance files are manually edited & generated file both.
I can't ignore these messages...
I have: