Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OBJECT directive #1117

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Conversation

s-ichikawa
Copy link
Contributor

I propose the implementation of the execution of directives for OBJECT.
When resolving an object that has a directive, the directive function can insert some process before and after executing resolver.

In the case of setting the same directive at field and object, it executes field directive before object directive.

If directive for OBJECT should do other behaviors or in other execute timing, I will close this PR and rewrite.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vvakame vvakame requested a review from vektah March 26, 2020 11:43
@vektah
Copy link
Collaborator

vektah commented Apr 24, 2020

Sweet, this looks super clean 🎉

@vektah vektah merged commit 0a40481 into 99designs:master Apr 24, 2020
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants