skip struct fields with incompatible types #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
bindObject
to ignore fields that cannot be automatically mapped from a struct. In the case of a type mismatch, the generated resolver will now require a method for the field, as if there were no matching field on the struct to begin with. This allows the logic for mapping field values to be provided as-needed, making cases like #82 hopefully easier to work with.Previously this case would result in a fatal error (code gen would fail with a type mismatch error).
Example scenario (with this change):
Schema:
Application struct (mapped with
types.json
):Result:
One could then simply define
User_createdAt
to maptime.Time -> *string
andUser_listOfEnums
to mapListOfEnum -> []FooEnum
.