-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention math.rand for the todo ID #1489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinmbeaulieu
pushed a commit
to kevinmbeaulieu/gqlgen
that referenced
this pull request
Apr 6, 2021
zhevron
pushed a commit
to zhevron/gqlgen
that referenced
this pull request
Apr 8, 2021
zhevron
pushed a commit
to zhevron/gqlgen
that referenced
this pull request
Apr 8, 2021
bluejay9676
pushed a commit
to ConsultingMD/gqlgen
that referenced
this pull request
Nov 15, 2021
commit 7db941a56e742dca10cbba1e32d4d09458cdc8ef Author: Carl Dunham <carl.dunham@team.neustar> Date: Wed Oct 20 06:06:56 2021 -0700 Fix 1138: nested fieldset support (#1669) * formatting * update federation schema to latest Apollo spec * add nested FieldSet support to @key and @requires directives also: handle extra spaces in FieldSet upgrade deps in federation integration tests commit 488a31fc12979b825b166cf6f317f4b27ee456a0 Author: Jonathan Duck <Duckbrain30@gmail.com> Date: Tue Oct 19 04:23:27 2021 -0700 ContextMarshaler (#1652) * Add interface and detection for ContextMarshaler * Test error on float marshalling * Revert prettier changes * Rename context test * Only use the erroring float printer * Test that context is passed to marshal functions * Update scalar docs to include the context * Generate the examples * Move ContextMarshaller test code to new followschema * Resolve conflict a little more Signed-off-by: Steve Coffman <steve@khanacademy.org> * Replicate sclar test for singlefile Co-authored-by: Steve Coffman <steve@khanacademy.org> commit a626d9b47e54e4439976d3ad333dfefe4c2710d6 Author: John Maguire <john@defined.net> Date: Tue Oct 19 01:45:14 2021 -0400 Add ICMP to common initialisms (#1666) commit db4b5eb71b4959c3f8b68086b753ec3c01c5b4c9 Author: wilhelm <helm@hey.com> Date: Sat Oct 16 13:00:42 2021 +1100 Merge Inline Fragment Nested Interface Fields (#1663) commit 8b9737179d3ba08405ab6422fb8c4883dd8e720c Author: John Maguire <contact@johnmaguire.me> Date: Fri Oct 15 07:37:50 2021 -0400 Update directives doc page (#1660) * Update directives doc page * Add back one beloved piece of jargon Co-authored-by: Steve Coffman <StevenACoffman@users.noreply.github.com> commit 1f500016aedcb9bc35eb9964b55730efe966ef5e Author: Kevin Beaulieu <kevinmbeaulieu@gmail.com> Date: Fri Oct 15 04:08:50 2021 -0700 Add follow-schema layout for exec (#1309) * Define ExecConfig separate from PackageConfig When support for writing generated code to a directory instead of a single file is added, ExecConfig will need additional fields that will not be relevant to other users of PackageConfig. * Add single-file, follow-schema layouts When `ExecLayout` is set to `follow-schema`, output generated code to a directory instead of a single file. Each file in the output directory will correspond to a single *.graphql schema file (plus a root!.generated.go file containing top-level definitions that are not specific to a single schema file). `ExecLayout` defaults to `single-file`, which is the current behavior, so this new functionality is opt-in. These layouts expose similar functionality to the `ResolverLayout`s with the same name, just applied to `exec` instead of `resolver`. Resolves issue #1265. * Rebase, regenerate Signed-off-by: Steve Coffman <steve@khanacademy.org> Co-authored-by: Steve Coffman <steve@khanacademy.org> commit 129783590c9cb8c709a2b0e9cbb7b69f022ee78a Author: Alex Sonneveld <Alex.sonneveld@99designs.com> Date: Fri Oct 15 21:40:03 2021 +1100 Update GQLgen test client to work with multipart form data (take 2) (#1661) * Update GQLgen test client to work with multipart form data Update the GQLgen to support multipart form data, like those present within the fileupload examples. - Add missing space between "unsupported encoding " and failing content-type header error (cherry picked from commit 101842f73fb79b10c1299bb40506080e08543ec6) * Add WithFiles client option for fileupload GQLgen client tests Add a `WithFiles` GQLgen client option to support the fileupload input within tests, using the core Golang `os` package and File type, which converts `os.File`s to their appropriate multipart form data within a request. - If there are no files this should just simply convert a `application/json` Content-Type to supported `multipart/form-data` (cherry picked from commit 08ef942416c98a2cadf61223308a3ff3c879d1c9) * Update fileupload test to use GQLgen test client Update the fileupload test to use the GQLgen test client and `WithFiles` option to remove the need for `createUploadRequest` helper with raw http posts - Fix setting the Content Type by using the appropriate `http` package function to dectect it + https://godoc.org/net/http#DetectContentType (cherry picked from commit 5e573d51440eba9d457adb4186772577b28ef085) * Update WithFiles option test with multipart Reader (cherry picked from commit 6dfa3cbe0647138e80a59a0c1d55dd9c900f96f2) * Update file upload tests `WithFiles` option Update the file upload tests to use the GQL test client and its `WithFiles` option to remove the need for a custom raw HTTP post request builder `createUploadRequest`. - Also update `WithFiles` option to group & map identical files; e.g. ``` { "0": ["variables.req.0.file", "variables.req.1.file"] } ``` (cherry picked from commit 486d9f1b2b200701f9ce6b386736a633547c1441) * Make sure `WithFiles` does not add duplicates to multipart form data (cherry picked from commit 0c2364d8495553051d97ab805618b006fcd9eddb) * Fix use of byte vs string in `WithFiles` tests (cherry picked from commit ba10b5b1c52a74e63e825ee57c235254e8821e0d) * Fix strict withFiles option test for race conditions Fix a problem with how strict the test's expected response was for tests with files in their request, since it always expected a strict order of files input that is somewhat random or dependent on what OS it is running the test on and/or race condition commit 7435403cf94ce8147fdd9d473a5469d63e7e5b38 Author: Corey Winkelmann <350215+CoreyWinkelmann@users.noreply.github.com> Date: Thu Oct 14 07:22:10 2021 -0600 Adds RootFieldInterceptor to extension interfaces (#1647) * Adds RootFieldInterceptor to extension interfaces * #1647 Regenerates the integration folder * Regenerates example folder * #1647 Adds Root Field Context separate from Field Context * Re-generate after changes Signed-off-by: Steve Coffman <steve@khanacademy.org> Co-authored-by: Steve Coffman <steve@khanacademy.org> commit 8b25c9e005c44ae3730eca83445fa7f7223481d1 Author: Hooman Yar <hooman.yar@gmail.com> Date: Wed Oct 13 17:37:53 2021 -0700 Add a config option to skip running "go mod tidy" on code generation (#1644) Co-authored-by: Hooman Yar <hooman.yar@coinbase.com> commit 658195b79d8c9072a90419ce3ddccda4e430ebf0 Author: Steve Coffman <StevenACoffman@users.noreply.github.com> Date: Wed Oct 13 20:11:27 2021 -0400 Revert "Update GQLgen test client to work with multipart form data (#1418)" (#1659) This reverts commit 1318f12792e86c76a2cdff9132ebac5b3e30e148. commit 41c867658a9eacf94b3c682121b03727e18940d5 Author: Steve Coffman <StevenACoffman@users.noreply.github.com> Date: Wed Oct 13 19:57:02 2021 -0400 Revert 1595 (#1658) Signed-off-by: Steve Coffman <steve@khanacademy.org> commit 8359f9749e6fd54be20325ff6aafb05503124238 Author: foreverest <v.dmitry.zabello@reddit.com> Date: Wed Oct 13 08:41:24 2021 -0700 Allow custom websocket upgrader (#1595) commit 1318f12792e86c76a2cdff9132ebac5b3e30e148 Author: Alex Sonneveld <Alex.sonneveld@99designs.com> Date: Thu Oct 14 00:33:29 2021 +1100 Update GQLgen test client to work with multipart form data (#1418) * Update GQLgen test client to work with multipart form data Update the GQLgen to support multipart form data, like those present within the fileupload examples. - Add missing space between "unsupported encoding " and failing content-type header error * Add WithFiles client option for fileupload GQLgen client tests Add a `WithFiles` GQLgen client option to support the fileupload input within tests, using the core Golang `os` package and File type, which converts `os.File`s to their appropriate multipart form data within a request. - If there are no files this should just simply convert a `application/json` Content-Type to supported `multipart/form-data` * Update fileupload test to use GQLgen test client Update the fileupload test to use the GQLgen test client and `WithFiles` option to remove the need for `createUploadRequest` helper with raw http posts - Fix setting the Content Type by using the appropriate `http` package function to dectect it + https://godoc.org/net/http#DetectContentType * Update WithFiles option test with multipart Reader * Update file upload tests `WithFiles` option Update the file upload tests to use the GQL test client and its `WithFiles` option to remove the need for a custom raw HTTP post request builder `createUploadRequest`. - Also update `WithFiles` option to group & map identical files; e.g. ``` { "0": ["variables.req.0.file", "variables.req.1.file"] } ``` * Make sure `WithFiles` does not add duplicates to multipart form data * Fix use of byte vs string in `WithFiles` tests commit 6758654c4e28dc0589147c9e962c9d4c1fd44705 Author: Masahiro Wakame <vvakame+dev@gmail.com> Date: Wed Oct 13 22:19:36 2021 +0900 raise panic when nested @requires are used on federation (#1655) commit f6c35be2128d8d0ec6c0c0d63bc0f135292ab5fe Author: Thomas Prebble <6523587+tprebs@users.noreply.github.com> Date: Wed Oct 13 14:12:52 2021 +0100 Add ReplacePlugin option to replace a specific plugin (#1657) * Add Helper Option for replacing plugins * Update recipe to use ReplacePlugin instead of NoPlugin and AddPlugin * fix linting issue on comment commit f8c46600aa005be4d62e52ca6f4a0467480c58c2 Author: Carl Dunham <cdunham@gmail.com> Date: Tue Oct 12 19:15:51 2021 -0700 fix double indirect bug (#1604) * invalid code generated * update code generation for pointer-to-pointer updating fixes #1587 commit 629c91a2dff9982a5c469f25e8076ab7737e167a Author: Bicky Eric Kantona <bickyeric@ymail.com> Date: Tue Oct 12 21:57:52 2021 +0700 remove extra WithOperationContext call (#1641) commit 35199c49ab02648b518d5653ee25eac3e3627602 Author: Travis Cline <travis.cline@gmail.com> Date: Tue Oct 12 07:55:29 2021 -0700 codegen: ensure Elem present before using (#1317) commit bfea93cdf3594edf0924e5ecd251eea09a1d35cb Author: Dan Wendorf <github@danwendorf.com> Date: Tue Oct 12 07:48:09 2021 -0700 Reload config packages after generating models (#1491) If models are generated in a package that has already been loaded, and that package refers to another package that has already been loaded, we can find ourselves in a position where it appears that a GQL `union` is not satisfied. For example, if we have: ``` union Subject = User ``` with this gqlgen.yml in github.com/wendorf/gqlgen-error/gql: ``` schema: - schema.graphql exec: filename: generated.go model: filename: models_gen.go models: User: model: github.com/wendorf/gqlgen-error/gql.User Subject: model: github.com/wendorf/gqlgen-error/models.Subject ``` Note that our User model is in the github.com/wendorf/gqlgen-error.gql package, and our models_gen.go will be generated in that same package. When we try to run gqlgen, we get this error: ``` merging type systems failed: unable to bind to interface: github.com/wendorf/gqlgen-error/gql.User does not satisfy the interface github.com/wendorf/gqlgen-error/models.Subject ``` Digging deeper, it's because we use types.Implements in codegen/interface.go, which does a shallow object comparison. Because the type has been reloaded, it refers to a _different_ interface type object than the one we're comparing against, and get a false negative. By clearing the package cache and repopulating it, the whole package cache is generated at the same time, and comparisons across packages work. To see a demo of this, check out https://github.com/wendorf/gqlgen-error and try the following: 1. Checkout the works-with-v0.10.2 branch and `go generate ./...` to see that it works 2. Checkout the breaks-with-v0.13.0 branch (or run go get github.com/99designs/gqlgen@v0.13.0 yourself) and `go generate ./...` to see errors 3. Checkout the works-with-pull-request branch and `go generate ./...` to see that it works again. This branch adds a go.mod replace directive to use the gqlgen code in this PR. The demo starts at v0.10.2 since it is the last release without this problem. https://github.com/99designs/gqlgen/pull/1020 introduces the code that fails in this scenario. commit 9e0817cdc7428ea9f3a1542faaca72ce9c5f317c Author: Thomas Prebble <6523587+tprebs@users.noreply.github.com> Date: Tue Oct 12 15:40:13 2021 +0100 Add graphql schema aware field level hook to modelgen (#1650) * Add ast aware field level hook to modelgen Currently, the only mechanism for extending the model generation is to use a BuildMutateHook at the end of the model generation process. This can be quite limiting as the hook only has scope of the model build and not the graphql schema which has been parsed. This change adds a hook at the end of the field creation process which provides access to the parsed graphql type definition and field definition. This allows for more flexibility for example adding additional tags to the model based off custom directives * Add recipe for using the modelgen FieldMutateHook * fix goimport linting issue in models_test commit af2ac061db4e08616cecff2ed74649465ee5fc20 Author: Vivek J <65152794+vnj-uber@users.noreply.github.com> Date: Tue Oct 12 20:06:03 2021 +0530 handling unconventional naming used in type names (#1549) * handling unconventional naming used in type names * Fix merge resolution mistake * Fix merge resolution mistake Signed-off-by: Steve Coffman <steve@khanacademy.org> Co-authored-by: Steve Coffman <StevenACoffman@users.noreply.github.com> commit 393f755421ae42d207655984dbe6b8b990440384 Author: dylanhuang <j75689@gmail.com> Date: Tue Oct 12 07:46:42 2021 +0800 add extraTag directive (#1173) commit fd1bd7c9b3b3804ce1b90b786cd3fb9281918882 Author: Suraj Chafle <5341407+schafle@users.noreply.github.com> Date: Mon Oct 11 16:31:10 2021 -0700 adding support for sending extension with gqlgen client (#1633) Co-authored-by: Suraj Chafle <suraj.chafle@crowdstrike.com> commit 589a774290cfaf8f39d6099650e930c6f10cd670 Author: Tim Kuhlman <tkuhlman@users.noreply.github.com> Date: Mon Oct 11 17:28:12 2021 -0600 Enable lowercase type names in GraphQL schema to properly render (#1359) The difficulty with lowercased type names is that in go code any lowercased name is not exported. This change makes the names title case for go code while preserving the proper case when interacting with the GraphQL schema. Co-authored-by: Liam Murphy <liamphmurphy@gmail.com> commit 50f6a2aa603842fcdc158ab135fa117d1716d7e2 Author: Steve Coffman <StevenACoffman@users.noreply.github.com> Date: Mon Oct 11 09:16:01 2021 -0400 Fixes #1653: update docs and wrap error if not *gqlerror.Error (#1654) Signed-off-by: Steve Coffman <steve@khanacademy.org> commit 7081dedb0efc6ed650118c7fce65ca3bdb33b8de Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Oct 10 10:02:58 2021 -0400 Bump tmpl from 1.0.4 to 1.0.5 in /integration (#1627) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 5287e4e5f30548d233f58111d128787c673c7f01 Author: Richard Lindhout <richardlindhout96@gmail.com> Date: Sun Oct 10 16:02:15 2021 +0200 Add QR and KVK to common initialisms (#1419) * Add QR and KVK to common initialisms * Update templates.go * Sort commonInitialisms Co-authored-by: Steve Coffman <StevenACoffman@users.noreply.github.com> commit f9df1a46601a23df87d364b33cc9c5564d77edd8 Author: Cameron Brill <c00brill@gmail.com> Date: Sun Oct 10 22:00:40 2021 +0900 Update time format for `Time` scalar (#1648) * Use more precise time format * update test * update docs * Apply suggestions from code review * Update scalars.md commit 77c757f0cf9f18de02f3b9e6a235a51dd2c75259 Merge: e60dc7af 47ce074a Author: Steve Coffman <StevenACoffman@users.noreply.github.com> Date: Sun Oct 10 08:53:13 2021 -0400 Merge pull request #1640 from minus7/master Fix example run instructions commit e60dc7af373aeca15f48df234c1cb90d4909db5d Merge: 0c63f1d1 43b56cba Author: Steve Coffman <StevenACoffman@users.noreply.github.com> Date: Sun Oct 10 08:31:50 2021 -0400 Merge pull request #1619 from Khan/benkraft.mod-tidy-stdout Forward `go mod tidy` stdout/stderr commit 0c63f1d10f508f528037c94c5cdb9f29af890098 Merge: a3d9e8ce 481a4e44 Author: Steve Coffman <StevenACoffman@users.noreply.github.com> Date: Sun Oct 10 08:15:39 2021 -0400 Merge pull request #1515 from OpenSourceProjects/time Marshaling & Unmarshaling time return initial value commit a3d9e8ce9689533ab8c3ab4b3b4cd22df3cbfa03 Author: Ashish Malik <87957768+ash99d@users.noreply.github.com> Date: Thu Oct 7 22:37:05 2021 +1100 Remove redundant favicon (#1638) commit 210c1aa6edf8b34d6e2f35e8c66b3d404cf7e8eb Author: wilhelm <helm@hey.com> Date: Thu Oct 7 22:21:57 2021 +1100 Appropriately Handle Falsy Default Field Values (#1623) commit 47ce074a3c30a981bbeef8f3465fca4330aba783 Author: minus <minus@mnus.de> Date: Sat Oct 2 16:28:06 2021 +0200 Fix example run instructions Making ./example a separate Go module [1] broke the `go run` invocations listed in a few example readmes [2]. Using relative paths from the respective example directory should be clear enough. [1]: commit f93fb2489285eef0542c4aa7b11341a8479b606a / issue/PR #1607 [2]: example/todo/server/server.go:10:2: no required module provides package github.com/99designs/gqlgen/example/todo; to add it: go get github.com/99designs/gqlgen/example/todo commit 1a0b19feff6f02d2af6631c9d847bc243f8ede39 Author: Michael Tibben <michael.tibben@99designs.com> Date: Tue Sep 28 14:04:59 2021 +1000 Update README.md commit d999828375978c666728167f75a208fd727b4b15 Merge: 2f6919ff f93f73ac Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Sep 23 07:01:01 2021 +1000 Merge pull request #1628 from robertmarsal/patch-1 Fix typo in the getting-started docs commit f93f73ac395209cd158862b86b2a0c136bc3e11b Author: Robert Marsal <507871+robertmarsal@users.noreply.github.com> Date: Wed Sep 22 16:03:09 2021 +0100 Fix typo in the getting-started docs commit 2f6919ff74dd165d58c0c2039e3fb1fc1f72b598 Merge: 880cd73d c53bc0e5 Author: Michael Tibben <michael.tibben@99designs.com> Date: Sun Sep 19 10:09:43 2021 +1000 Merge pull request #1624 from FlymeDllVa/master Update disabling Introspection commit c53bc0e53cacb9f9930ec3125388b85820241a27 Author: Dmitry Gridnev <dgridnev@ozon.ru> Date: Sat Sep 18 18:35:19 2021 +0300 Update disabling Introspection commit 880cd73dbe0d602168639a7d3f59638473a4a91c Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 17 10:59:36 2021 +1000 Update README.md commit eec81df05e18dd9ac977b5a661964df212bf4627 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 17 10:58:07 2021 +1000 Update README.md commit 43b56cbaf3f1de1d1ad379055ab1de157592cf38 Author: Ben Kraft <benkraft@khanacademy.org> Date: Wed Sep 15 14:18:27 2021 -0700 Forward `go mod tidy` stdout/stderr This is a command that can fail (in my case I think for stupid reasons in a hell of my own construction, but nonetheless). Right now we just get ``` $ go run github.com/Khan/webapp/dev/cmd/gqlgen tidy failed: go mod tidy failed: exit status 1 exit status 3 ``` which is not the most informative. Now, instead, we'll forward its output to our own stdout/stderr rather than devnull. commit ce7a8ee469108e1c2dd62511249199312b32729a Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 21:03:12 2021 +1000 Fix link in docs commit 488cf7e8180e653c7a085c137d14734c5897393b Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 20:08:05 2021 +1000 Update docs/content/getting-started.md commit 73809f6912ed01c8ea18dbb5d7ea98e803ddb9c7 Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 19:48:47 2021 +1000 Update getting started commit b938e55811966ef5ff96cc911597327af92c493c Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 19:18:09 2021 +1000 Update README.md commit cacd49a6d0421093bdb67d17551ea0323ceb438a Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 17:01:51 2021 +1000 Update README.md commit 7d549d6476853a33aaacab76c3d954bed9d6f0cd Merge: 41d6926f 5c52f27c Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 15:40:45 2021 +1000 Merge pull request #1617 from 99designs/update-docs-for-go1.17 Update docs for getting started commit 5c52f27c49d65d97a05bba14fc12ce8873d2b959 Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 15 15:04:08 2021 +1000 Update docs for getting started commit 41d6926f38922cd0a01d93f30ac8702d9f9bcf48 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 15 10:49:35 2021 +1000 Replace gitter with discord in contributing.md commit 24d4edcf128f7fa327d97fd85d087fef2e230943 Author: Michael Tibben <michael.tibben@99designs.com> Date: Tue Sep 14 11:42:45 2021 +1000 Update README.md commit 2272e05bc00cc9f38e6d3179a8981651812acbba Author: Michael Tibben <michael.tibben@99designs.com> Date: Tue Sep 14 11:35:35 2021 +1000 Update README.md commit ef4d4a38a229a485bec4f111a1112b47c638382e Merge: 473f0671 00ed6fb1 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 19:57:48 2021 +1000 Merge pull request #1614 from 99designs/go-1.16 Also test against 1.16 commit 00ed6fb1a74b1c94d195b38025b1721f9c77db90 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 19:52:37 2021 +1000 Also test against 1.16 commit 473f0671b5d9c3a0bb9afe6c2de2b4f10d9eeef6 Merge: bf9b34aa 6960c0c2 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 18:59:05 2021 +1000 Merge pull request #1613 from 99designs/bump-non-module-deps Clean up non-module deps commit 6960c0c2adbe9e2359e0d7cb332d1eaceccb6b6f Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 17:58:07 2021 +1000 Bump non-module deps commit bf9b34aae2eb079913aacbb75fa8b3dff7c45c32 Merge: 85dd47bb 85e7a4a0 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 17:40:56 2021 +1000 Merge pull request #1612 from 99designs/update-linter Update golangci linter commit 85e7a4a0aae4c80c8522350d17400184fac48882 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 17:34:21 2021 +1000 Linting fixes commit 777dabde381c1c4b1b6bb0316658f65cce22c654 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 17:27:42 2021 +1000 Update the linter commit 85dd47bb8ca9547ebc3530f441aab8a99e16b5a7 Merge: 890f5f66 f93fb248 Author: Luke Cawood <luke.cawood@99designs.com> Date: Mon Sep 13 17:23:23 2021 +1000 Merge pull request #1607 from 99designs/example-module [POC/RFC] Split examples into separate go module commit f93fb2489285eef0542c4aa7b11341a8479b606a Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 14:50:35 2021 +1000 Split examples into separate go module commit 890f5f66fb2059ccd760bb7dd708b04166ed274d Merge: 1116ea6c 9162c53f Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 14:10:04 2021 +1000 Merge pull request #1610 from 99designs/go-1.17 Update to go 1.17 commit 9162c53fc32471c96d874764b47bf71f0c493fce Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 13:20:57 2021 +1000 Fix newlines in error messages commit f67a5b2611ca89dfb0ffd3dd4c72cebb8f2532ef Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 13 12:46:35 2021 +1000 Update github.com/urfave/cli/v2 commit 1116ea6cdc1f3c66af5e214365af7ed67d464a52 Merge: ed8054b0 682a7d66 Author: Michael Tibben <michael.tibben@99designs.com> Date: Sat Sep 11 07:32:32 2021 +1000 Merge pull request #1608 from jjmengze/patch-1 fix Options response header commit 71e5784352a3c6d7b91bf9f2307fcebc959ab8b0 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 22:53:55 2021 +1000 Simplify init commit a8903ca2aca700217fe29c2b8c262b6ee45959fb Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 21:42:48 2021 +1000 Wrap errors commit a644175b8f80ba1fbc220799b4cd9ce257ccc7ac Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 21:36:34 2021 +1000 Update error checks for go 1.17 commit c6b9f2926b14c0367ffb82db4e2c250c4fc7aab2 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 21:30:02 2021 +1000 go mod tidy commit 1c63cfff8f2943d2ab3316f850b89bba83548c05 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 21:29:35 2021 +1000 Add missing model package file commit 59da23feb5e135b3c2c0ce976b0214643147e85c Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 21:19:23 2021 +1000 Create a temporary file on init so go recognises the directory as a package commit 682a7d662bd2491213c45b8556461533cee56997 Author: MengZeLee <adnt587@gmail.com> Date: Fri Sep 10 15:09:36 2021 +0800 fix Options response header operatee the header of ResponseWriter should before WriteHeader called commit ed8054b054c4e7dae1c2ad12d86a8d4d26c194e9 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 13:32:59 2021 +1000 Update to a post-release version commit 5216db5849eb5298722ee233cc98fa1e85db3237 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 10:54:05 2021 +1000 Fix TestAutobinding test failure by checking the module commit 90c5eb59b0fde89eb0c42e5b9c5ad276a8335f8f Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 09:49:50 2021 +1000 go generate commit 402f44950b4694a3a5fd65d3225e06ccd76fbf9d Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 09:44:59 2021 +1000 go fmt commit 10bb1ef262af49031c3d5224eb094586e6fd8083 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 09:41:17 2021 +1000 Go mod tidy commit ed210385722431111b8842ec7da7b42051b77d91 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 09:38:37 2021 +1000 Update to go 1.17 commit 5c7acc1bc8198ed57a38867ae0c452987da91911 Author: Michael Tibben <michael.tibben@99designs.com> Date: Fri Sep 10 09:21:30 2021 +1000 Fix imports commit d747387036fb300fc384fa6f17a76f6547dc6a1b Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Sep 9 14:33:30 2021 +1000 Update plugin/servergen/server.go Co-authored-by: Luke Cawood <luke.cawood@99designs.com> commit a6c6de6b73741caa1ac02cf8adea79afcd4ed78b Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Sep 9 14:33:21 2021 +1000 Update plugin/resolvergen/resolver.go Co-authored-by: Luke Cawood <luke.cawood@99designs.com> commit de7d19c812bed562d2841c6c08fb080d706195d1 Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Sep 9 14:33:10 2021 +1000 Update codegen/config/config_test.go Co-authored-by: Luke Cawood <luke.cawood@99designs.com> commit 60d80d4aee61337793d2cade8a7ab35c2892613a Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Sep 9 14:32:57 2021 +1000 Update cmd/gen.go Co-authored-by: Luke Cawood <luke.cawood@99designs.com> commit a991e3e73ec4d624f6b23124d83198ce51af8ae3 Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Sep 8 21:50:43 2021 +1000 Update errors to use go1.13 semantics commit 8f179be920401bf993630693b0586cfc51dbdd04 Merge: 5048f992 5adb73bb Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 20:46:49 2021 +1000 Merge pull request #1581 from tsh96/master Bypass complexity limit on __Schema queries. commit 5048f9927e54828b07ea47cd79d1b30b3858d320 Merge: 1e2b303a 91b54787 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 20:36:55 2021 +1000 Merge pull request #1525 from Code-Hex/fix/support-input-object support input object directive commit 1e2b303a8cc8a596fc24cb79b560c33bec2c9ad6 Merge: e7df3e5c e82b401d Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 20:30:24 2021 +1000 Merge pull request #1526 from epulze/fix/allow-more-types allow more than 10 different import sources with types commit e7df3e5c7d33dd485ec928c4be07f421423c722b Merge: 06e4fe88 f00e2c3f Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 20:29:11 2021 +1000 Merge pull request #1405 from alexsn/subsciption-complete-on-panic subscriptions: send complete message on resolver panic commit 06e4fe8810d14649a5b6e2f9c1482eff28c86ddb Merge: a557c90c f0ccab79 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 17:06:29 2021 +1000 Merge pull request #1529 from mathieupost/master Return type loading errors in config.Binder.FindObject commit a557c90cd741f808f4065e9846b0c59ba1d29f9b Merge: 522cab59 fa371b9b Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 16:56:54 2021 +1000 Merge pull request #1340 from bickyeric/master serialize ID just like String commit 522cab59d1ecb9813610013a60596da2edf91f33 Merge: 56451d92 95653193 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 16:53:07 2021 +1000 Merge pull request #1285 from Khan/benkraft.federation Resolve requests for federation entities in parallel commit 56451d92d626be6d15317b44e448c857297ddb68 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Sep 8 16:17:35 2021 +1000 release v0.14.0 commit 8e97969b06e6d63160f1252a92bb36972c55a0b6 Merge: b978593c 82ca6e24 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 13:35:26 2021 +1000 Merge pull request #1358 from mtsmfm/patch-1 Create package declaration to run dataloaden commit b978593ca852ca1968a93501eaebec7bdc7fd359 Merge: 71507dfc 18b5df19 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 13:33:34 2021 +1000 Merge pull request #1387 from Khan/benkraft.config codegen/config: Add a new API to finish an already-validated config commit 71507dfc1be232bed3d4d08f63d61f8c8a9cdd77 Merge: 23577b69 a9c8fabf Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 13:26:30 2021 +1000 Merge pull request #1408 from max107/patch-1 int64 support graphql/string.go commit 23577b696e36bf3342c685b20ec48b8484158518 Merge: db6154b9 971da82c Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 13:25:11 2021 +1000 Merge pull request #1460 from snxk/edit-docs-recipe-gin Edited the Gin-Gonic Recipe Docs commit db6154b9eac60bf3ec82b959c0e6bfe1e79f0bb8 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:48:11 2021 +1000 Update README.md commit cecda16053ffe9f2b689c6e7da987eabe5c2515f Merge: 023f66df cc957171 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:39:03 2021 +1000 Merge pull request #1464 from frederikhors/patch-1 Add goreportcard badge commit cc957171fc77df6bfb0749ddd66e1d8d9ca24afe Merge: 269a58ad 023f66df Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:38:37 2021 +1000 Merge branch 'master' into patch-1 commit 023f66df41a1761ab36eed6c68733e1dd85e5608 Merge: 50c2028a c4bf36c5 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:36:15 2021 +1000 Merge pull request #1465 from frederikhors/patch-2 Add coveralls badge commit 50c2028a9574c89f59d7720b84bf720e07a6a974 Merge: a0232dd2 eb36f04f Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:32:41 2021 +1000 Merge pull request #1497 from polytomic/stable-introspection Return introspection document in stable order commit a0232dd21c2fe51d8d52e6541d7a01d50bbaab4d Merge: 4e059eba fd133c0b Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:22:17 2021 +1000 Merge pull request #1603 from 99designs/dependabot/npm_and_yarn/integration/normalize-url-4.5.1 Bump normalize-url from 4.5.0 to 4.5.1 in /integration commit 4e059eba3d28e0b27445ba71ffe670852c84c096 Merge: 43705d45 24d8c703 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:22:09 2021 +1000 Merge pull request #1602 from 99designs/dependabot/npm_and_yarn/integration/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8 in /integration commit 43705d459a1340ef0e7c4ee46af97cec592c976c Merge: 1f2465c6 de89d3a6 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:21:58 2021 +1000 Merge pull request #1601 from 99designs/dependabot/npm_and_yarn/integration/y18n-3.2.2 Bump y18n from 3.2.1 to 3.2.2 in /integration commit 1f2465c6d29a731ad1b9dd5b08d57da37ce14043 Merge: bbdebd4c 13db6111 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:21:50 2021 +1000 Merge pull request #1600 from 99designs/dependabot/npm_and_yarn/integration/browserslist-4.17.0 Bump browserslist from 4.14.0 to 4.17.0 in /integration commit bbdebd4c55194a2e18428a33546adbecea99b05d Merge: 900a37af 94e9406e Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:20:25 2021 +1000 Merge pull request #1599 from 99designs/dependabot/npm_and_yarn/integration/hosted-git-info-2.8.9 Bump hosted-git-info from 2.8.5 to 2.8.9 in /integration commit 900a37af53ee048bd10a755d227bebf11b0bc53f Merge: 9d334cdd 36be94ff Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:20:15 2021 +1000 Merge pull request #1598 from 99designs/dependabot/npm_and_yarn/integration/node-fetch-2.6.1 Bump node-fetch from 2.6.0 to 2.6.1 in /integration commit 9d334cdd222c4616165e0ef168086c4d178d4313 Merge: 56181e8a 721158f3 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:20:07 2021 +1000 Merge pull request #1597 from 99designs/dependabot/npm_and_yarn/integration/ws-7.4.6 Bump ws from 7.3.1 to 7.4.6 in /integration commit 56181e8abe857e229a3e63e8d634582647480681 Merge: 2b3b7212 9f851619 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:18:37 2021 +1000 Merge pull request #1365 from frederikhors/add-uint,-uint64,-uint32-types-in-graphql add uint, uint64, uint32 types in graphql pkg commit fd133c0b7a2d552e73da63180e3af2e4bf4aa434 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:17:10 2021 +0000 Bump normalize-url from 4.5.0 to 4.5.1 in /integration Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/sindresorhus/normalize-url/releases) - [Commits](https://github.com/sindresorhus/normalize-url/commits) --- updated-dependencies: - dependency-name: normalize-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit 24d8c703c122cd007fe2eb81457a2eae89b49be8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:16:57 2021 +0000 Bump ini from 1.3.5 to 1.3.8 in /integration Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8) --- updated-dependencies: - dependency-name: ini dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit de89d3a6f28cffb44704f6f9b6876c8c81d9f7aa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:16:54 2021 +0000 Bump y18n from 3.2.1 to 3.2.2 in /integration Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit 13db61111eae250a02ead0cd9faa456d98dc007b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:16:52 2021 +0000 Bump browserslist from 4.14.0 to 4.17.0 in /integration Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.0 to 4.17.0. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](https://github.com/browserslist/browserslist/compare/4.14.0...4.17.0) --- updated-dependencies: - dependency-name: browserslist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit 94e9406e93a5afee6f193fc936f200287c4f5847 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:16:46 2021 +0000 Bump hosted-git-info from 2.8.5 to 2.8.9 in /integration Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.5 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.5...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit 36be94fff25cfe702f6b93a7fd595972ceb41a4b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:16:44 2021 +0000 Bump node-fetch from 2.6.0 to 2.6.1 in /integration Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md) - [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.0...v2.6.1) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> commit 721158f3cdb00744c33380c05ab020f31b894325 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 6 02:16:42 2021 +0000 Bump ws from 7.3.1 to 7.4.6 in /integration Bumps [ws](https://github.com/websockets/ws) from 7.3.1 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.3.1...7.4.6) --- updated-dependencies: - dependency-name: ws dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> commit 2b3b721258bb22d0da26790a9383047cf1ef444c Merge: 5b43833d edf630a3 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:16:07 2021 +1000 Merge pull request #1594 from 99designs/dependabot/npm_and_yarn/integration/tar-6.1.11 Bump tar from 6.0.5 to 6.1.11 in /integration commit 5b43833db94d42332553ba79103f3d054c461e62 Merge: 55b028ca 01b25c55 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:15:51 2021 +1000 Merge pull request #1582 from 99designs/dependabot/npm_and_yarn/integration/path-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7 in /integration commit 55b028cadc5e16421f0cb06ec9ffa94febee72a4 Merge: 9a214e80 29133c11 Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Sep 6 12:15:35 2021 +1000 Merge pull request #1584 from nullism/patch-1 Fix spaces -> tabs typo in authentication.md commit edf630a3da614949b9f0246299b08a61d25f6635 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Aug 31 18:37:14 2021 +0000 Bump tar from 6.0.5 to 6.1.11 in /integration Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.11. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.11) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit 29133c1152b4d89ab897bf75e0114fffad32351e Author: Aaron M <webgovernor@gmail.com> Date: Sat Aug 14 08:41:37 2021 -0600 Fix spaces -> tabs typo in authentication.md The indentation here was supposed to be a tab rather than spaces so the readme was off. commit 01b25c5534453574296c52065c04d1923b3607c7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Aug 10 19:14:23 2021 +0000 Bump path-parse from 1.0.6 to 1.0.7 in /integration Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> commit 5adb73bbba5375f07cd21d1fe498c6a252b6f933 Author: TSH96 <tansiahow1996@gmail.com> Date: Sat Aug 7 17:04:30 2021 +0800 add bypass __schema field test case commit 54cef3ddcdd3c5e106f8347ccd8afd9bbb8bdb44 Author: TSH96 <tansiahow1996@gmail.com> Date: Sat Aug 7 16:47:14 2021 +0800 Bypass complexity limit on __Schema queries. commit 9a214e80158b78443cfb53bb10059df9c36d352e Merge: 01197437 0e9d9c3a Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Jul 29 11:11:07 2021 +1000 Merge pull request #1451 from sanjeevchopra/patch-1 doc only change: updated sample code for disabling introspection commit 011974377ac4437c060d963c97f9c04f1fd1bfae Merge: e3293b53 918801ea Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Jul 29 11:10:31 2021 +1000 Merge pull request #1417 from RicCu/patch-1 Use mutation instead of query in 'Changesets' doc example commit e3293b53d07145d4932a7b05fea534763cc8af12 Merge: a4d67855 5ef5d14f Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Jul 29 11:09:14 2021 +1000 Merge pull request #1444 from lisowskibraeden/patch-1 Update cors.md commit a4d6785526f2423e5cd7d2a35bf2f6e68ab66bf7 Merge: 7e38dd46 843edd9e Author: Michael Tibben <michael.tibben@99designs.com> Date: Thu Jul 29 11:06:07 2021 +1000 Merge pull request #1517 from ShivangGoswami/patch-1 Update apq.md function definition mismatch commit eb36f04ffde9a706467839b0aadb5671e4ed16a9 Author: Nathan Yergler <nathan@polytomic.com> Date: Tue Mar 23 11:19:58 2021 -0700 Return introspection document in stable order This avoids spurious changes when generating client code using something like graphql-codegen. commit 7e38dd46943cc103a82c6bca0c2510e5d1291edc Merge: 88f2b8a7 be9a0791 Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Jul 28 14:15:43 2021 +1000 Merge pull request #1568 from DanyHenriquez/patch-1 Update apq.md commit 88f2b8a77680f49b07238cdafc03d429e5fb75b7 Merge: 5ad012e3 3e45ddc1 Author: Michael Tibben <michael.tibben@99designs.com> Date: Wed Jul 28 14:15:09 2021 +1000 Merge pull request #1572 from talhaguy/dataloaders-doc-casing Correct minor casing issue commit be9a0791a9217a05e105914dbae11e29a651ea54 Author: Dany Henriquez <2287263+DanyHenriquez@users.noreply.github.com> Date: Sun Jul 25 11:07:00 2021 +0200 Update apq.md commit 3e45ddc151232c5d05eb719f4722a9306f06afa1 Author: talhaguy <talhaguy@gmail.com> Date: Sun Jul 18 11:34:46 2021 -0700 Correct minor casing issue commit 145101e439f5460cbe7e85f8618e4de74104b676 Author: Dany Henriquez <2287263+DanyHenriquez@users.noreply.github.com> Date: Fri Jul 2 16:58:44 2021 +0200 Update apq.md commit f0ccab79549f184b1225dbc946d703400673aa5b Author: Mathieu Post <mathieupost@gmail.com> Date: Thu May 6 11:43:27 2021 +0200 Return type loading errors in config.Binder.FindObject commit 91b54787166e1dd26e2f95493e02a43130950105 Author: Kei Kamikawa <code-hex@users.noreply.github.com> Date: Fri Apr 30 12:20:21 2021 +0900 generated go code commit 1efc152e4f9399a908620d1d4c1198b9662cb181 Author: Kei Kamikawa <code-hex@users.noreply.github.com> Date: Fri Apr 30 10:58:45 2021 +0900 supported INPUT_OBJECT directive commit e82b401ddd97fe807a5066d3702b391ec317a358 Author: Simon Borgström <simon.borgstrom@interactivesolutions.se> Date: Wed Apr 28 15:11:00 2021 +0200 allow more than 10 different import sources with types commit 843edd9ea507bcf50b02cb43d0543f3fdf0ae875 Author: Shivang Goswami <shivang.goswami@outlook.com> Date: Mon Apr 19 19:34:31 2021 +0530 Update apq.md function definition mismatch line 67: cache, err := NewCache(cfg.RedisAddress, 24*time.Hour) line 41: func NewCache(redisAddress string, password string,ttl time.Duration) (*Cache, error) either password should be removed from 41 or added in line 67 Proposed the first one for now. commit 5ad012e3d7be1127706b9c8a3da0378df3a98ec1 Author: MichaelJCompton <michael.compton@99designs.com> Date: Thu Apr 15 16:58:09 2021 +1000 Revert "Merge pull request #1511 from a8m/a8m/restore-cwd" This reverts commit f4bf1f591b6a3884041876deb64ce0dd70c3c883, reversing changes made to 3f68ea27a1a9fea2064caf877f7e24d00aa439e6. Reverting this because it will break existing setups, moving where generated files get put. commit bb59cc43aa5bae2595ec823f8d7e67369e990082 Author: Michael Compton <michael.compton@99designs.com> Date: Thu Apr 15 10:58:11 2021 +1000 Add a CHANGELOG.md (#1512) commit 058a365a3608a0d8e9704ee8715eb6c70e7cc902 Merge: bf2fdf44 23eec791 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Apr 14 13:40:04 2021 +1000 Merge pull request #1456 from skaji/issue-1455 Fix data race (issue #1455) commit bf2fdf4401b3c77a4d032572f641787eb99e8b71 Merge: f4bf1f59 4e881981 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Apr 14 10:27:26 2021 +1000 Merge pull request #1514 from 99designs/bump-gqlparser Bump gqlparser to v2.2.0 commit 481a4e44cbc114382dee087feb9cf18c15907d4a Author: Franky W <frankywahl@users.noreply.github.com> Date: Tue Apr 13 10:03:09 2021 +0200 Marshaling & Unmarshaling time return initial value There was a lack of symmetry that would prevent times for being symmetrical. That is because time.Parse actually parses an RFC3339Nano implicitly, thereby allowing nanosecond resolution on unmarshaling a time. Therefore we now marshal into nanoseconds, getting more information into GraphQL times when querying for a time, and restoring the symmetry commit 4e881981de33f2e2bf1fef11c2bf833995f60719 Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Apr 13 16:35:43 2021 +1000 Bump to gqlparser v2.2.0 commit 1d768a29c960df5d54f6e675e0338619d5b04bfd Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Apr 13 12:38:17 2021 +1000 Add test covering single element -> slice coercion commit f57d1a0285eebce853a6a008da3c9c7b4eb77c57 Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Apr 13 12:24:50 2021 +1000 Bump gqlparser to master & support repeated directives commit f4bf1f591b6a3884041876deb64ce0dd70c3c883 Merge: 3f68ea27 3cfc5b14 Author: Luke Cawood <luke.cawood@99designs.com> Date: Mon Apr 12 14:35:13 2021 +1000 Merge pull request #1511 from a8m/a8m/restore-cwd codegen/config: restore current working directory after changing it commit 3f68ea27a1a9fea2064caf877f7e24d00aa439e6 Author: ananya saxena <ananyasaxena1@gmail.com> Date: Sun Apr 11 21:16:10 2021 -0700 Special handling for pointers to slices (#1363) commit c920bdebb02f1fc4c406b9f36a63114556303657 Merge: 35b80a72 478c3f08 Author: Michael Compton <michael.compton@99designs.com> Date: Mon Apr 12 14:11:59 2021 +1000 Merge pull request #1449 from steebchen/feat-prisma-compat feat(codegen): handle (v, ok) methods commit 3cfc5b14d89ff8250656e40f967d1b0fae9de374 Author: Ariel Mashraki <ariel@mashraki.co.il> Date: Sun Apr 11 13:48:51 2021 +0300 codegen/config: restore current working directory after changing it Before this commit, a call to config.LoadConfigFromDefaultLocations changed the working directory to the directory that contains the gqlgen config file. This commit changes the implementation to restore the working directory after loading the config. commit 35b80a72f6cdae48cf98c68128d96d9d70e5f756 Merge: 463debae 8c3e64e1 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Mar 31 12:05:04 2021 +1100 Merge pull request #1495 from Niennienzz/improve-apq-doc Update apq.md commit 463debae6b4eb068aff0b882e6ea292bfac0fae2 Merge: 29e7bccb 03b57f3e Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Mar 31 11:33:41 2021 +1100 Merge pull request #1503 from nana4gonta/resolve-vulnerability Resolve indirect dependency vulnerability in example commit 29e7bccbf7fcb7d8d7f8c47cabd7abdc542cdcc6 Merge: 9a4c80ab e02db808 Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Mar 30 17:36:27 2021 +1100 Merge pull request #1501 from 99designs/fix-init-1.16 Run go mod tidy after code generation commit 9a4c80abc704d77c9471f5b7ee47d64cbced0348 Merge: 7985db44 5f21f9d9 Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Mar 30 17:34:58 2021 +1100 Merge pull request #1502 from 99designs/rm-chi Remove chi from dataloader example commit 5f21f9d9ecdedca84810d7fda605c6eddd1f2335 Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Mar 30 17:28:38 2021 +1100 Remove chi from dataloader example commit e02db808a857ce1ec31861b3b0b54fa4d5cb85e6 Author: Luke Cawood <luke.cawood@99designs.com> Date: Tue Mar 30 13:00:26 2021 +1100 Run go mod tidy after code generation commit 8c3e64e1965081ff07bbe9353dd9246817232887 Author: Joe Zhou <zhehui.zhou@outlook.com> Date: Sun Mar 21 01:26:48 2021 -0400 Improve APQ documentation commit 03b57f3e01f34504261550aacb0b08f64843b6ad Author: KzKarino <kazuhiro@rhodonit.com> Date: Sat Mar 20 22:22:16 2021 +0900 Run go mod tidy commit 54e387c45e97e7b7922f06baf1c6e57dd5a7ff2e Author: KzKarino <kazuhiro@rhodonit.com> Date: Sat Mar 20 21:20:12 2021 +0900 Resolve indirect dependency vulnerability in example commit 7985db44855b160c1f2552bedbfed5bc150fc840 Author: Michael Compton <michael.compton@99designs.com> Date: Tue Mar 16 09:38:18 2021 +1100 Mention math.rand for the todo ID (#1489) commit b995f7f1fa2e18b4016d167739213ec5de95a053 Author: Michael Compton <michael.compton@99designs.com> Date: Mon Mar 15 17:09:56 2021 +1100 Make spacing consistent (#1488) commit 52ded95125beecffe5ad61d37ef942fbac2d726f Merge: 82a8e1bf 67e652ad Author: Michael Compton <michael.compton@99designs.com> Date: Mon Mar 15 16:31:48 2021 +1100 Merge pull request #1459 from aaronArinder/getting-started-server-section getting started: make running server own section commit 82a8e1bf39aec5225e05deb8e026083d859d50ef Author: Michael Compton <michael.compton@99designs.com> Date: Mon Mar 15 15:04:14 2021 +1100 Make it clearer what happened on init. (#1487) commit 7258af5f837802cd1673afd0778ee7a76b8c2471 Merge: 4fead489 aa531ed8 Author: Michael Compton <michael.compton@99designs.com> Date: Mon Mar 15 14:42:56 2021 +1100 Merge pull request #1458 from aaronArinder/getting-started-wording getting started: making the resolver fn section clearer commit 4fead4895bc44aff95fd06a4a5a3aa4b184cc2ff Merge: 58e3225e 02b14003 Author: Michael Compton <michael.compton@99designs.com> Date: Mon Mar 15 14:37:26 2021 +1100 Merge pull request #1452 from fmyd/fix/formatted-query-indent prettified some indentation commit 58e3225ed3100371d286869e9a2a4b19ec9810e6 Merge: 997da421 1fac78e9 Author: Luke Cawood <luke.cawood@99designs.com> Date: Fri Mar 12 13:13:21 2021 +1100 Merge pull request #1480 from wilhelmeek/double-bubble Bubble Null from List Element to Nearest Nullable Ancestor commit 1fac78e9b4d68a76d3ae2fc0b980e7569cc3eb3c Author: Wilhelm <helm@hey.com> Date: Mon Mar 8 10:38:46 2021 +1100 Add test case for nullable field commit 469e31bddf27395e5d124694e683cecc44fa00d3 Author: Wilhelm <helm@hey.com> Date: Sat Mar 6 13:00:03 2021 +1100 Fix bad test case commit 635b1aef316c528b6f17416057d41a0948b42a2d Author: Wilhelm <helm@hey.com> Date: Sat Mar 6 12:51:20 2021 +1100 Add Test Case commit 0b5da15cd87f315af0bc851a50f21362e4312002 Author: Wilhelm <helm@hey.com> Date: Sat Mar 6 12:10:13 2021 +1100 Check in generated code commit 55b774ba48146540bdef95d8cc027998eca7fd13 Author: Wilhelm <helm@hey.com> Date: Sat Mar 6 11:20:31 2021 +1100 Fix type ref commit 45903a6597846c5ae71d82f156fc3ee3b743ec75 Author: Wilhelm <helm@hey.com> Date: Sat Mar 6 11:13:46 2021 +1100 Handle nillable list elements commit c4bf36c5bd94b64e8d13060a77a7b8ac8050b794 Author: frederikhors <41120635+frederikhors@users.noreply.github.com> Date: Sat Feb 13 12:00:32 2021 +0100 Add coveralls badge commit 269a58ad547f61b4ceaaa6586ed7898cafc041c1 Author: frederikhors <41120635+frederikhors@users.noreply.github.com> Date: Sat Feb 13 11:33:43 2021 +0100 Add goreportcard badge commit 971da82c8e3d1cf7cca31bb9cfff91cab2a460d3 Author: Sayan Mallick <snyxmk@gmail.com> Date: Sat Feb 13 10:10:16 2021 +0530 Updated gin.md commit 41ad51ceefc190b70c4b5fa77c77641ede1d7281 Author: Sayan Mallick <snyxmk@gmail.com> Date: Tue Feb 9 23:13:16 2021 +0530 Edited the Gin-Gonic Recipe Docs commit 67e652ad974418a9f6fa9cfa4c97eebc3db910bf Author: Aaron Arinder <aaronarinder@gmail.com> Date: Sun Feb 7 14:57:18 2021 -0500 getting started: separate example mutation/query commit 31d339ab390a2c4119fec42c54edabebd96ef730 Author: Aaron Arinder <aaronarinder@gmail.com> Date: Sun Feb 7 14:53:54 2021 -0500 getting started: make running server own section commit aa531ed87f327f0e03d243744a5f5e810d5c1230 Author: Aaron Arinder <aaronarinder@gmail.com> Date: Sun Feb 7 14:44:19 2021 -0500 getting started: more wording updates commit 5b2531aee84fa4f971ea83c083f7113b2d6b7c6e Author: Aaron Arinder <aaronarinder@gmail.com> Date: Sun Feb 7 14:43:34 2021 -0500 getting started: wording update commit ada1b928096db2d4cff8d476e62d8a84c41da47e Author: Aaron Arinder <aaronarinder@gmail.com> Date: Sun Feb 7 14:40:35 2021 -0500 getting started: updating wording around implementing unimpl fns commit 23eec79139fd4735d50d397a081edfefad09fd27 Author: Shoichi Kaji <skaji@cpan.org> Date: Sat Feb 6 22:43:59 2021 +0900 go generate ./... commit 18678b15ecbcf6075356623fbc0902606e440513 Author: Shoichi Kaji <skaji@cpan.org> Date: Sat Feb 6 22:35:05 2021 +0900 Fix data race The argument of unmarshalInput may be the same for concurrent use if it pass as graphql "variables". So we have to copy it before setting default values commit 02b140038d1f192af2ff2cc05a08a691b300ec94 Author: fmyd <yudai.furumoto@gunosy.com> Date: Thu Jan 28 17:53:21 2021 +0900 fomatted query indent commit 0e9d9c3a9d072c6e2262bf742705d723be8d2508 Author: sanjeevchopra <sanjeevchopra@users.noreply.github.com> Date: Wed Jan 27 17:16:11 2021 -0800 updated sample code for disabling introspection commit 478c3f08b20fadd31c538ddd90bb7e88a4e2c1a9 Author: Luca Steeb <contact@luca-steeb.com> Date: Wed Jan 27 21:47:14 2021 +0700 feat(codegen): handle (v, ok) methods commit 5ef5d14f864eb355ffb96d2727a19b61c5d2b362 Author: Braeden Lisowski <47958989+lisowskibraeden@users.noreply.github.com> Date: Sat Jan 23 19:23:58 2021 -0600 Update cors.md I had problems reading this page and applying it to my project. With these changes it worked on my end commit 956531936e9a7a0d9012c246153531a9bcf3c7bd Author: Ben Kraft <benkraft@khanacademy.org> Date: Fri Aug 14 16:17:38 2020 -0700 Resolve requests for federation entities in parallel In apollo federation, we may be asked for data about a list of entities. These can typically be resolved in parallel, just as with sibling fields in ordinary GraphQL queries. Now we do! I also changed the behavior such that if one lookup fails, we don't cancel the others. This is more consistent with the behavior of other resolvers, and is more natural now that they execute in parallel. This, plus panic handling, required a little refactoring. The examples probably give the clearest picture of the changes. (And the clearest test; the changed functionality is already exercised by `integration-test.js` as watching the test server logs will attest.) Fixes #1278. commit 997da421b0b80884fcb43c8c6a22d747564b301c Merge: 862762c7 be4514c6 Author: Luke Cawood <luke.cawood@99designs.com> Date: Wed Jan 13 13:03:29 2021 +1100 Merge pull request #1436 from ddouglas/patch-1 Upgrade graphql-playground to 1.7.26 commit be4514c60a3cef3673b003a545818eb67e620506 Author: David Douglas <48367195+ddouglas@users.noreply.github.com> Date: Tue Jan 12 20:14:12 2021 -0500 Upgrade graphql-playground to 1.7.26 commit 918801eac861c0ceb5cf45969745f674b823ef7c Author: Ricardo Cuenca <jricardocuenca@gmail.com> Date: Fri Dec 11 19:21:22 2020 -0600 Change 'Changeset' doc example to mutation commit 862762c77bae8b5f119c401d037358cfaf33fa52 Merge: b484fc27 c30ff3dd Author: Luke Cawood <luke.cawood@99designs.com> Date: Mon Dec 7 17:07:23 2020 +1100 Merge pull request #1409 from zikaeroh/chi-mod Upgrade go-chi to v1.5.1 with module support commit c30ff3ddec18b7a9465e0b81ab0af301d3899141 Author: zikaeroh <48577114+zikaeroh@users.noreply.github.com> Date: Sun Dec 6 20:08:14 2020 -0800 Upgrade go-chi to v1.5.1 with module support commit a9c8fabff6d56c9c523ca68764dcd9f9e6cd4f45 Author: Maxim <862272+max107@users.noreply.github.com> Date: Sun Dec 6 20:11:28 2020 +0300 int64 support commit f00e2c3f3d70a58ae85ab05d5f2b8adf543a306d Author: Alex Snast <alexsn@fb.com> Date: Thu Dec 3 15:34:20 2020 +0200 subscriptions: send complete message on resolver panic commit b484fc27b153639c6d96a3f1df7e952d587749be Merge: 4cc031af 1123ba0d Author: Michael Tibben <michael.tibben@99designs.com> Date: Mon Nov 30 16:59:15 2020 +1100 Merge pull request #1401 from oseifrimpong/patch-1 fix typo commit 4cc031afba041dd41b9f533cba3ac1399e8b66cd Merge: 2af51336 d0d5f7db Author: Adam Scarr <adam@vektah.net> Date: Mon Nov 30 15:47:25 2020 +1100 Merge pull request #1394 from j2gg0s/fix-default-recover-func bugfix: Default Recover func should return gqlerror.Error commit 2af51336b421f45bd5076f5ee144d4d44c15ec54 Merge: 34a442c7 89a9f743 Author: Adam Scarr <adam@vektah.net> Date: Mon Nov 30 15:44:58 2020 +1100 Merge pull request #1400 from 99designs/sanstale Remove stale bot commit 34a442c7980f5ba363f58aaee67b9ddaa77d7520 Merge: 0e12bfbf 4628ef84 Author: Adam Scarr <adam@vektah.net> Date: Mon Nov 30 15:44:44 2020 +1100 Merge pull request #1399 from 99designs/prevent-possible-error-deadlock Dont hold error lock when calling into error presenters commit 1123ba0da6c0cd0f5ab71d7e4c8aae7a5e8f40b4 Author: Obed Osei Frimpong <3536601+oseifrimpong@users.noreply.github.com> Date: Thu Nov 26 03:40:55 2020 +0800 Update gin.md Changed this: `In your router file, define the handlers for the GraphQL and Playground endpoints in two different methods and tie then together in the Gin router: ` to: `In your router file, define the handlers for the GraphQL and Playground endpoints in two different methods and tie them together in the Gin router: ` commit 89a9f743240e589c476df6a01e122564314ec215 Author: Adam Scarr <adam@vektah.net> Date: Wed Nov 25 13:12:05 2020 +1100 Remove stale bot We tried it, but it's just causing more work both for maintainers and reporters of errors. commit 4628ef8422c2118ee482dc15a65eedff5144d34c Author: Adam Scarr <adam@flip.com.au> Date: Wed Nov 25 12:49:27 2020 +1100 Dont hold error lock when calling into error presenters This can result in a deadlock if error handling code calls GetErrors. commit d0d5f7db3d8f09f087abedfe3958423c9f5e4fb9 Author: j2gg0s <j2gg0s@gmail.com> Date: Sun Nov 15 19:14:28 2020 +0800 bugfix: Default Recover func should return gqlerror.Error commit 18b5df19bba282e0217dc269f6e9e211b52fc707 Author: Ben Kraft <benkraft@khanacademy.org> Date: Tue Nov 10 15:37:22 2020 -0800 codegen/config: Add a new API to finish an already-validated config LoadConfig parses the config from yaml, but it does a bunch of other things too. We want to parse the config ourselves, so that we can have extra fields which will be passed to our plugins. Right now, that means we either have to duplicate all of LoadConfig, or write the config back to disk only to ask gqlgen re-parse it. In this commit, I expose a new function that does all the parts of LoadConfig other than the actual YAML-reading: that way, a caller who wants to parse the YAML themselves (or otherwise programmatically compute the config) can do so without having to write it back to disk. An alternative would be to move all this logic to Config.Init(), but that could break existing clients. Either way would work for us. commit 0e12bfbfde3b8fc8e54241fcd107c6301c98c6fa Merge: 22c5d1f5 1c9f24b2 Author: Adam Scarr <adam@vektah.net> Date: Sun Nov 8 16:31:39 2020 +1100 Merge pull request #1269 from dqn/new-line-at-the-end-of-file Add a new line to end of the file schema.graphqls commit 22c5d1f56eb081104b586c6a73f9324ded90a8b5 Merge: 88cffee4 07c06594 Author: Adam Scarr <adam@vektah.net> Date: Sun Nov 8 16:24:56 2020 +1100 Merge pull request #1303 from kunalpowar/inline-directives-doc Update README.md commit 88cffee4fc5a29b2899d70d93b4ef64c145e4722 Merge: de8af66c 1e8c34e5 Author: Adam Scarr <adam@vektah.net> Date: Sun Nov 8 16:21:23 2020 +1100 Merge pull request #1356 from maapteh/chore/chat-example-update Chore: update Chat example commit 1e8c34e540c04b5bb203a385788e0e02111f0afb Author: Adam Scarr <adam@vektah.net> Date: Sun Nov 8 16:20:38 2020 +1100 Dont export Input commit de8af66c892a5b2ec8b2ce7ed274003d7706d904 Merge: 651eda40 09756915 Author: Adam Scarr <adam@vektah.net> Date: Sun Nov 8 15:50:42 2020 +1100 Merge pull request #1360 from Captain-K-101/master Update introspection.md commit 0975691550f23be6b68c29b57840e2af4698eac4 Author: Adam Scarr <adam@flip.com.au> Date: Sun Nov 8 15:49:07 2020 +1100 Update introspection docs commit 651eda40fe4318ec7acd48e7e1f1eb933331c22d Merge: 3a31a752 94252e04 Author: Adam Scarr <adam@vektah.net> Date: Sun Nov 8 15:29:06 2020 +1100 Merge pull request #1374 from rudylee/docs-file-upload-small-typo Fix small typo in file upload docs commit 94252e047b6ab16532c003003511762e6bf4f655 Author: Adam Scarr <adam@flip.com.au> Date: Sun Nov 8 15:27:44 2020 +1100 singleUpload consistency commit c9d346f549ca75ab19097ea8bf90f0d3666cc117 Author: Rudy Lee <rudylee1988@gmail.com> Date: Sat Oct 24 15:19:12 2020 +1100 Fix small typo in file upload docs commit 9f85161930220becde384662e4da9f4b457ce19f Author: frederikhors <41120635+frederikhors@users.noreply.github.com> Date: Tue Oct 20 19:46:58 2020 +0200 add uint, uint64, uint32 types in graphql commit 0625525f663e7fc8d246f5435c1545beef137173 Author: Captain-K <44168298+Captain-K-101@users.noreply.github.com> Date: Fri …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1441