Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate at end #166

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Validate at end #166

merged 3 commits into from
Jul 5, 2018

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Jul 5, 2018

When loading the program during codegen allow errors and try to generate, assuming these errors wont affect codegen. Once the code has been generated, validate the program a second time and show those errors. Any error here may have affected codegen (eg if the thing you were trying to bind to had invalid code resolvers would have been generated instead of binding directly)

Alternative to #160
Fixes #152

@vektah vektah mentioned this pull request Jul 5, 2018
@vektah vektah force-pushed the validate-at-end branch from 51dbc6f to cc78971 Compare July 5, 2018 04:31
@vektah vektah force-pushed the validate-at-end branch from b83ac43 to fca1e08 Compare July 5, 2018 04:42
@vektah vektah merged commit faf095f into master Jul 5, 2018
@vektah vektah deleted the validate-at-end branch July 5, 2018 04:45
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gqlgen on new RootResolver return declared name XxxResolver
1 participant