Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1955: only print message on @key found on interfaces #1956

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix 1955: only print message on @key found on interfaces #1956

merged 1 commit into from
Feb 8, 2022

Conversation

carldunham
Copy link
Contributor

Describe your PR and link to any relevant issues.
Fixes #1955 and adds a test for @extends handling.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Feb 8, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 75.26% when pulling 3623f20 on carldunham:cd/allow-interface-keys into 9262b35 on 99designs:master.

@carldunham carldunham force-pushed the cd/allow-interface-keys branch from 284fc99 to 3623f20 Compare February 8, 2022 18:44
@StevenACoffman StevenACoffman merged commit 56bfb18 into 99designs:master Feb 8, 2022
@carldunham carldunham deleted the cd/allow-interface-keys branch February 9, 2022 00:53
@StevenACoffman StevenACoffman added the federation Related to Apollo federation label Jun 14, 2023
@StevenACoffman StevenACoffman mentioned this pull request Jun 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
federation Related to Apollo federation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@key on interface panics
3 participants
@carldunham @coveralls @StevenACoffman