Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to generate model for intermediate interface #1982

Merged

Conversation

Code-Hex
Copy link
Contributor

@Code-Hex Code-Hex commented Feb 22, 2022

Describe your PR and link to any relevant issues.

Closes #1690
I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

I hope "small change, small release". Thanks.

ref: vektah/gqlparser#180

@Code-Hex Code-Hex changed the title Add/gen intermediate interfaces support to generate model for intermediate interface Feb 22, 2022
@coveralls
Copy link

coveralls commented Feb 22, 2022

Coverage Status

Coverage increased (+0.004%) to 74.295% when pulling 818cbea on Code-Hex:add/gen-intermediate-interfaces into 9546de2 on 99designs:master.

@Code-Hex
Copy link
Contributor Author

Code-Hex commented Feb 22, 2022

I will update the version of the module when only this change is released
vektah/gqlparser#169

@StevenACoffman
Copy link
Collaborator

Can you look into the test failures?

@Code-Hex
Copy link
Contributor Author

Code-Hex commented Feb 22, 2022

@StevenACoffman this failure caused by gomod. (currently used master branch)

@Code-Hex
Copy link
Contributor Author

But what happened...

.github/workflows/check-fmt
  .github/workflows/check-fmt
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.16.14/x64
go: github.com/99designs/gqlgen@v0.0.0-00010101000000-000000000000 requires
	github.com/vektah/gqlparser/v[2](https://github.com/99designs/gqlgen/runs/5282597021?check_suite_focus=true#step:5:2)@v2.[3](https://github.com/99designs/gqlgen/runs/5282597021?check_suite_focus=true#step:5:3).2-0.20220221192817-3e788[6](https://github.com/99designs/gqlgen/runs/5282597021?check_suite_focus=true#step:5:6)dd3df0: missing go.sum entry; to add it:
	go mod download github.com/vektah/gqlparser/v2

@Code-Hex
Copy link
Contributor Author

Probably fixed

@Code-Hex
Copy link
Contributor Author

I need to fix the test for windows... 🙇

@Code-Hex
Copy link
Contributor Author

Code-Hex commented Feb 22, 2022

@StevenACoffman @vektah I have done.
I recommend releasing the gqlparser just contains interface implements before merging this PR. and update gqlparser to the version in this PR. I hope "small change, small release". Thanks

@StevenACoffman
Copy link
Collaborator

Thank you for your work, but there's still some lingering work to be done in vektah/gqlparser#181 before we can make a release there.

@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Feb 28, 2022

Rebased and force pushed, so looks good to me.

@StevenACoffman StevenACoffman force-pushed the add/gen-intermediate-interfaces branch from f017473 to 818cbea Compare February 28, 2022 22:20
@StevenACoffman StevenACoffman merged commit 82fefdb into 99designs:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support intermediate interfaces
3 participants