Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix introspection for description to be nullable #2008

Merged

Conversation

Code-Hex
Copy link
Contributor

@Code-Hex Code-Hex commented Mar 1, 2022

description field must be description may return a String or null.

spec: https://spec.graphql.org/October2021/#sec-Schema-Introspection

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Mar 1, 2022

Coverage Status

Coverage increased (+0.2%) to 74.455% when pulling 69dcd57 on Code-Hex:fix/introspection-description into 82fefdb on 99designs:master.

@Code-Hex Code-Hex changed the title fix introspection for description to be nullable WIP: fix introspection for description to be nullable Mar 1, 2022
@@ -34,7 +34,6 @@ input ListCoercion {
strVal: [String]
}

""""""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix this using this PR

@Code-Hex Code-Hex changed the title WIP: fix introspection for description to be nullable fix introspection for description to be nullable Mar 1, 2022
@Code-Hex
Copy link
Contributor Author

Code-Hex commented Mar 1, 2022

@StevenACoffman Could you check this?

@StevenACoffman StevenACoffman merged commit 5236fb0 into 99designs:master Mar 1, 2022
@Code-Hex Code-Hex deleted the fix/introspection-description branch March 1, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants