-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new plugin signatures #2011
Conversation
@StevenACoffman any feedback? |
Oh wow, I somehow overlooked this completely. I'm sorry! |
I'm pretty hesitant to break backwards compatibility, and at the time this was first proposed, it was extremely important to regain the confidence of the community since there had been a period of instability. I also agree forcing panic-recover as an error-passing mechanism is definitely gross. The pugins that are part of this repository are pretty easy to update, and all the Ent folks are quite responsive. gqlgen Plugins
|
I did a quick check and the only plugins that use InjectSources are autogql, ent and federation. Also it shouldn't be a breaking change. Ielft the previous interface intact |
I can't push to your branch, but I resolved the conflicts and rebased: If you can either apply those changes, or resolve the conflicts yourself, I will merge this PR, and again sorry for overlooking it. |
thanks @StevenACoffman |
Thanks! I really appreciate your patience and commitment to this improvement. |
Describe your PR and link to any relevant issues.
See #1994 #1995
I have: