Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed model gen for multiple implemented type #2021

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

Code-Hex
Copy link
Contributor

@Code-Hex Code-Hex commented Mar 2, 2022

I found a bug that when GraphQL type implements multiple interfaces, it does not generate the model methods of the interfaces those interfaces implement.

We would appreciate it if you could merge this fix and release it as version v0.17.1 as soon as possible 🙇

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 74.486% when pulling e4a22fc on Code-Hex:fix-implemented-types into d31cf6b on 99designs:master.

@Code-Hex
Copy link
Contributor Author

Code-Hex commented Mar 2, 2022

CI has been failed at websocket timeout in integration tests. (unrelated with this PR)
it will be resolved if re-run workflow
https://github.com/99designs/gqlgen/runs/5388819457?check_suite_focus=true

@StevenACoffman StevenACoffman merged commit 74baaa1 into 99designs:master Mar 2, 2022
@Code-Hex Code-Hex deleted the fix-implemented-types branch March 2, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants