Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: allow binding methods with optional variadic arguments #2066

Merged
merged 1 commit into from
Mar 23, 2022
Merged

codegen: allow binding methods with optional variadic arguments #2066

merged 1 commit into from
Mar 23, 2022

Conversation

a8m
Copy link
Collaborator

@a8m a8m commented Mar 23, 2022

In some cases, as we have in Ent, the same method used for GraphQL binding can accept optional parameters.

@a8m a8m force-pushed the variadicmethod branch from b079cff to f65b661 Compare March 23, 2022 13:01
@coveralls
Copy link

coveralls commented Mar 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 74.48% when pulling f65b661 on a8m:variadicmethod into fba5edd on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Nice! Thanks!

@StevenACoffman StevenACoffman merged commit 36fb3dc into 99designs:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a8m @coveralls @StevenACoffman