-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update module mitchellh/mapstructure to 1.5.0 #2111
Conversation
@wilhelmeek If you have a chance to look at this, you have more experience with this than I do. |
If I update all of the go mods except for After some more trial-and-error: The For reference: |
8f626e9
to
0c03869
Compare
Thanks to @RobinCPel I was able to upgrade the rest and merged that as a separate PR, and I rebased this so it just shows the specific problem with this one library version. I'm not able to spend more time digging into what needs to change, but we'll need to wrestle with this eventually. |
I hope this helps to find the answer: mitchellh/mapstructure#290 |
Signed-off-by: Steve Coffman <steve@khanacademy.org>
0c03869
to
a87ba17
Compare
a9a3b21
to
e16abf9
Compare
Signed-off-by: Steve Coffman <steve@khanacademy.org>
e16abf9
to
9fd55d1
Compare
It looks like we were always taking the pointer of a pointer in the websocket code, and somehow this worked ok in the old mapstructure, but not in the newer versions. Line 55 in 9fd55d1
Special thanks to @jakezhu9 and @ubiuser who helped figure this out in mitchellh/mapstructure#290 (comment) |
Updating all module dependencies to the latest version causes a few WebSocket tests to fail. I wonder if @telemenar or @RobinCPel knows why updating mitchellh/mapstructure to 1.5.0 seems to break them.
Signed-off-by: Steve Coffman steve@khanacademy.org