-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of strings.Title with cases.Title #2268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My only concern before merging is if we introduce any breaking change by moving from strings.Title
to cases.Title
. Can you check please and add a link here? Thanks
Thanks! This was reported to Go in 2013 in golang/go#6801. I think that your usage of Given that, I'm not sure if adding further unit tests are necessary now, but as a note to our future selves, the two test cases I have used elsewhere for multilingual capitalization are dealing with unicode punctuation and language specific capitalization.
|
|
This removes the use of the deprecated
strings.Title
function and enables go 1.18 in CI while still working on Go 1.16+.Depends on #2266 (will rebase once that's in).