Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolver commit #2434

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

voslartomas
Copy link
Contributor

@voslartomas voslartomas commented Nov 25, 2022

I would like to add Generated by section into resolvers comments to be able to suppress linters. We have internal linters to have Copyright docs and also there is type queryResolver struct{ *Resolver } at the end of the file and our gocritic expects it to be defined before it's use.

If this is not possible, would it be possible to add possibility to add custom docs at the beginning and also fix order of queryResolver?

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Nov 25, 2022

Coverage Status

Coverage increased (+0.003%) to 75.657% when pulling a3e7a5b on voslartomas:feature/resolver-comment into 3087cf3 on 99designs:master.

@StevenACoffman StevenACoffman force-pushed the feature/resolver-comment branch from 92c6060 to 10bc173 Compare November 25, 2022 18:48
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman force-pushed the feature/resolver-comment branch from 10bc173 to a3e7a5b Compare November 25, 2022 18:54
@StevenACoffman StevenACoffman merged commit 89e91da into 99designs:master Nov 25, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

@voslartomas voslartomas deleted the feature/resolver-comment branch November 28, 2022 08:33
@voslartomas
Copy link
Contributor Author

Thank you, when are you planning to create new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants