Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to return multiple errors from resolvers raise than add it to stack. #2454

Merged
merged 10 commits into from
Dec 8, 2022

Conversation

atzedus
Copy link
Contributor

@atzedus atzedus commented Dec 7, 2022

Code detects gqlerror.List type returned from resolver and add all errors to stack.

I have:

  • Updated any relevant documentation (see docs)

Sometimes vscode warn about this while editing resolvers code.
Finally the resolver's code is editable and generated at the same time.
@coveralls
Copy link

coveralls commented Dec 7, 2022

Coverage Status

Coverage decreased (-0.09%) to 75.623% when pulling 4d74951 on atzedus:resolver_error_list_return into db1e3b8 on 99designs:master.

Roman A. Grigorovich and others added 5 commits December 7, 2022 22:40
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
Collaborator

There's something dumb about the generation in Go 1.18 that is off by one space from the generation in Go 1.16. I am hoping GCP AppEngine releases a new version this week so we can leave Go 1.16 support behind.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@atzedus
Copy link
Contributor Author

atzedus commented Dec 8, 2022

There's something dumb about the generation in Go 1.18 that is off by one space from the generation in Go 1.16. I am hoping GCP AppEngine releases a new version this week so we can leave Go 1.16 support behind.

Cool, thank you! :)

@giautm
Copy link
Contributor

giautm commented Dec 8, 2022

There's something dumb about the generation in Go 1.18 that is off by one space from the generation in Go 1.16. I am hoping GCP AppEngine releases a new version this week so we can leave Go 1.16 support behind.

@StevenACoffman: I just cross the thread on Google Issues Track, They already support go118 and go119 runtimes in public preview: https://cloud.google.com/appengine/docs/standard/go/runtime#go-1.19-preview

Thread: https://issuetracker.google.com/issues/241957454#comment18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants