Add Server-Sent Events transport #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! This is a great alternative to websockets for subscriptions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the feature request #329 and several articles about GraphQL subscriptions via Server-Sent Events, I started to implement an SSE transport that follows this protocol specification and is compatible with the graphql-sse library at the distinct connections mode.
The result is this PR. Besides tests and documentation, I added an SSE option to the chat example as well. Please try it.
Remarks: I didn't want to change the
Supports(r *http.Request)functions of the present transports to add a filter that rejects alltext/event-streamrequests, instead the order in which the transportSupports(r *http.Request)are called is essential. This can of course be solved the other way around if desired.Many thanks to the developers of gqlgen for this great library!