Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move minimum supported version to Go 1.18 #2556

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Move minimum supported version to Go 1.18 #2556

merged 5 commits into from
Feb 17, 2023

Conversation

StevenACoffman
Copy link
Collaborator

@StevenACoffman StevenACoffman commented Feb 16, 2023

Khan Academy upgraded to Go 1.19, so we can move up to at least Go 1.18. We can probably continue to support Go 1.18, but I am open to moving to Go 1.19 if there's compelling reasons like the very small correction to the scope of type parameters in method declarations or some of the library changes.

There are slight "go generate" differences (extra space in comments) between Go 1.18 and Go 1.19 versions to be wary of, so I am moving those to Go 1.19+ in github action matrix for linting.

Signed-off-by: Steve Coffman steve@khanacademy.org

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@coveralls
Copy link

coveralls commented Feb 16, 2023

Coverage Status

Coverage: 75.368% (+0.006%) from 75.362% when pulling f7123b9 on go119 into e36095f on master.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit a9e42e1 into master Feb 17, 2023
@StevenACoffman StevenACoffman deleted the go119 branch February 17, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants