Init Config Improvement #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewbyrne
force-pushed
the
init-improvements
branch
from
de0dc3d to
d724172
Compare
creativej
reviewed
Aug 6, 2018
| os.Exit(1) | ||
| } | ||
|
|
||
| if !os.IsNotExist(errors.Cause(err)) { |
There was a problem hiding this comment.
What if the above code found a config file but there's parsing errors?
There was a problem hiding this comment.
If there is a parse error then config will be nil and it will exit with 1 right? I think that's the correct behaviour. What do you think should happen?
There was a problem hiding this comment.
Yeah cool yeah that's what I am thinking too so we will need to handle that edge case then because I don't think
!os.IsNotExist(errors.Cause(err)) will catch it.
There was a problem hiding this comment.
Note the ! — I know it's a bit hard to read, but it's checking for the opposite case; basically any error except file not found.
There was a problem hiding this comment.
hrmm okay I guess that makes sense.
creativej
approved these changes
Aug 6, 2018
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Init Config Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init will currently fail with an obscure error message if a config file is found. This change fixes a couple of issues with the codepath, and outputs a better error message if a config file is located:
Also fixed a minor issue outputting the server filename.