Update extra fields type definition and plus docs about the feature #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chadxzs @StevenACoffman Hey guys! I've improved extra fields feature based on the Steven's suggestions. Please take a look and let me know if need to improve anything. Thanks! |
|
Nice! I'm going to merge this as is, but if there's any feedback from @chadxzs I'm happy to do that as a follow-up PR. |
2 tasks
|
Don't mind me, I'm getting acquainted with the codebase and review process by following along and helping where I can. Great work @auvn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2638
This PR is an improvement for the extra fields feature.
Type configuration was simplified and slice types were added.
I have: