Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small template fix to save space in the generated file #2841

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

PatrLind
Copy link
Contributor

@PatrLind PatrLind commented Nov 8, 2023

This fix saves some space in the generated.go file.
It just removes some unused code.

@coveralls
Copy link

coveralls commented Nov 10, 2023

Coverage Status

coverage: 76.204%. remained the same
when pulling 8c53b7a on PatrLind:template-fix
into c0ca509 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

It looks like you would need to run go generate ./...; cd _examples; go generate ./...

@PatrLind
Copy link
Contributor Author

I did that, but it generates no files to check in.
It seems the test forbids anyone to change the templates, so I guess this PR is not allowed. I should remove it probably.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
Collaborator

_examples is a separate module, so you need to re-generate from inside the _examples directory. I did that, and the linting works now.

@StevenACoffman StevenACoffman merged commit eb5cea7 into 99designs:master Nov 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants