testifylint v1.3.0 fixes

[StevenACoffman]

Inspired by @alexandear , I took a stab at upgrading testifylint and enabling some more of it's linters

After upgrading testifylint to v1.3.0, running testifylint --fix ./..., I got some test failures. Running testifylint ./... there were still a number of other new issues, so I followed those recommendations, and there were even more test failures.

I'm imagining that these are either:

1. longstanding issues that we just weren't noticing before or
2. incorrect adjustments to the existing tests.

However, even if we got all failures to pass, there are still a fair number of remaining lint issues around testify's require. being called inside handlers or goroutines.

These are problems that should also get fixed, but need some more work to address so I'm deferring that.

Wait, tell me about the legit issues that we are not addressing

This checker is a radically improved analogue of go vet's
testinggoroutine check.

The point of the check is that, according to the documentation,
functions leading to t.FailNow (essentially to runtime.GoExit) must only be used in the goroutine that runs the test.
Otherwise, they will not work as declared, namely, finish the test function.

You can disable the go-require checker and continue to use require as the current goroutine finisher, but this could lead

1. to possible resource leaks in tests;
2. to increasing confusion, because functions will be not used as intended.

Typically, any assertions inside goroutines are a marker of poor test architecture.
Try to execute them in the main goroutine and distribute the data necessary for this into it
(example).

Also a bad solution would be to simply replace all require in goroutines with assert
(like here)
– this will only mask the problem.

In addition, the checker warns about require in HTTP handlers (functions and methods whose signature matches
http.HandlerFunc), because handlers run in a separate
service goroutine that
services the HTTP connection. Terminating these goroutines can lead to undefined behaviour and difficulty debugging tests.
You can turn off the check using the --go-require.ignore-http-handlers flag.

P.S. Look at testify's issue, related to assertions in the goroutines.

List of remaining lint problems:

/gqlgen/client/client_test.go:24:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:25:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:32:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:49:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:50:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:51:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:52:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:53:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:54:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:55:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:56:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:86:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:101:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:115:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:116:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:117:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:133:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:134:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:150:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:151:3: go-require: do not use require in http handlers
/gqlgen/client/client_test.go:157:3: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:32:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:33:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:41:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:44:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:49:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:52:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:55:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:56:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:74:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:75:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:83:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:86:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:91:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:96:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:97:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:98:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:99:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:100:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:103:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:104:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:127:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:128:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:136:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:139:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:144:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:149:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:150:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:151:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:152:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:153:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:154:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:155:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:158:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:159:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:186:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:187:4: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:195:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:198:5: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:203:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:206:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:209:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:210:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:211:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:212:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:213:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:214:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:215:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:218:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:219:6: go-require: do not use require in http handlers
/gqlgen/client/withfilesoption_test.go:224:5: go-require: do not use require in http handlers
/gqlgen/graphql/handler/apollofederatedtracingv1/tracing_test.go:80:4: go-require: require must only be used in the goroutine running the test function
/gqlgen/graphql/handler/apollofederatedtracingv1/tracing_test.go:84:4: go-require: require must only be used in the goroutine running the test function
/gqlgen/graphql/handler/apollofederatedtracingv1/tracing_test.go:88:4: go-require: require must only be used in the goroutine running the test function
/gqlgen/graphql/handler/apollofederatedtracingv1/tracing_test.go:89:4: go-require: require must only be used in the goroutine running the test function

[StevenACoffman]

Just autofixes, I get these test failures:

--- FAIL: TestPackages (0.07s)
    --- FAIL: TestPackages/name_for_existing_package_does_not_load_again (0.02s)
        packages_test.go:59: 
            	Error Trace:	/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:59
            	            				/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:12
            	Error:      	Received unexpected error:
            	            	packages.Load: 
            	Test:       	TestPackages/name_for_existing_package_does_not_load_again
    --- FAIL: TestPackages/name_for_unknown_package_makes_name_only_load (0.02s)
        packages_test.go:59: 
            	Error Trace:	/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:59
            	            				/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:18
            	Error:      	Received unexpected error:
            	            	packages.Load: 
            	Test:       	TestPackages/name_for_unknown_package_makes_name_only_load
    --- FAIL: TestPackages/evicting_a_package_causes_it_to_load_again (0.01s)
        packages_test.go:59: 
            	Error Trace:	/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:59
            	            				/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:25
            	Error:      	Received unexpected error:
            	            	packages.Load: 
            	Test:       	TestPackages/evicting_a_package_causes_it_to_load_again
    --- FAIL: TestPackages/able_to_load_private_package_with_build_tags (0.02s)
        packages_test.go:59: 
            	Error Trace:	/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:59
            	            				/home/runner/work/gqlgen/gqlgen/internal/code/packages_test.go:34
            	Error:      	Received unexpected error:
            	            	packages.Load: 
            	Test:       	TestPackages/able_to_load_private_package_with_build_tags
FAIL

[alexandear]

@StevenACoffman Fixed some problems with tests here #3105, please take a look.

[erka]

InEpsilon doesn't expect 0 as value because the calculation will be return 0 delta

[coveralls]

coverage: 74.772% (+0.01%) from 74.762%
when pulling 7dddf3b on testifylint_v1_3_0_fixes
into bbb0c95 on master.

[StevenACoffman]

Thank you so much @erka and @alexandear !