-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go 1.23 support #3226
Go 1.23 support #3226
Conversation
Thanks! I made some minor changes. The coverage breaks if you run it for more than one version because coveralls will only accept the first one. Also the matrix is already pretty slow, and current version + one previous seems sufficient for support. |
This appears to be a breaking change - specifically Was this supposed to be included in a |
This PR in particular should not break compatibility, it just adds support for types.Alias if compiled with go 1.23, the CI is running it with older versions of go and it was compiling fine, what kind of compatibility issues are you running into? |
Added support for *types.Alias conditionally only applies to go1.23
Also updated GitHub Actions to run the pipelines with go 1.23
Describe your PR and link to any relevant issues.
Closes #3222
I have: