Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor graphql.NoCache. use string type keys #3332

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

adomaskizogian
Copy link
Contributor

@adomaskizogian adomaskizogian commented Oct 15, 2024

Fixes: #3331

All internal uses of cache use string type keys and leaves out the value type as generic parameter. The new generic NoCache implementation only allows specifying the key type and the value type is a pointer of the key type. Meaning if I specify the key type string the value type is *string. This implementation cannot be assigned in place of graphql.Cache[any]

I propose to fix this by updating the NoCache definition by dropping the key type and allowing to use only string as key, any as value

See #3179

@adomaskizogian adomaskizogian changed the title refactor graphql.NoCache by specifying cache key type string refactor graphql.NoCache. use string type keys Oct 15, 2024
@coveralls
Copy link

Coverage Status

coverage: 58.869% (-0.05%) from 58.915%
when pulling 4a7efdd on adomaskizogian:master
into 96429c1 on 99designs:master.

@StevenACoffman StevenACoffman merged commit f9eac5c into 99designs:master Oct 15, 2024
16 of 17 checks passed
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken graphql.NoCache implementation
3 participants