Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gouroutine leak when using subscriptions #339

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Sep 12, 2018

Fixes #336

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah force-pushed the fix-subscription-goroutine-leak branch from 0f0fc5f to 229a81b Compare September 12, 2018 02:26
Copy link

@JulienBreux JulienBreux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@JulienBreux
Copy link

Do you have plan a fix release? E.g. v0.5.1

Thanks again Adam!

@vektah vektah merged commit 869215a into master Sep 13, 2018
@vektah vektah deleted the fix-subscription-goroutine-leak branch September 13, 2018 01:44
@vektah
Copy link
Collaborator Author

vektah commented Sep 13, 2018

released in 0.5.1

@JulienBreux
Copy link

OMG! A big THX. Please send me your work or personal address for a gift!

cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
…utine-leak

Fix gouroutine leak when using subscriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants