-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand defer tests #3399
Expand defer tests #3399
Conversation
Not certain why the coverage job is failing: I regenerated the singlefile test server to rename the operations in the test... May be there is some golden test for the server codegen I do not know how to update? |
This Thanksgiving I am grateful for all those who maintain open source projects. 👍 |
Hey, thanks for circling back to this! I'm on my phone, but it looks like something is not quite right with the tests? |
Yeah no hurry or anything, but I don't quite know what I'm missing. Getting hundreds of "results did not match" on the schema-generated code for the singlefile test. If I had to guess you have a snapshot/goldenfile test for that code, but I didn't have time to track it down. Will look again today. |
OK, needed to update the followschema codegen test schema to match. Looks good. Will rebase on master but the coverage also looks good. |
0aaeeef
to
e4dff38
Compare
Thanks! Sorry about the tab character. This is extremely high quality. I really appreciated that you added such nice comments, especially since this is a draft spec, and you provide a nice trail of breadcrumbs for people to update it if the spec changes. |
As requested in #3384 (link), this updates the defer tests to cover using the
if
argument, and thelabel
argument for fragment spreads.Additionally, this PR:
@defer
, not just SSE, to ensure consistency between the implementations;Client.IncrementalHTTP
based onClient.SSE
that can be used to test@defer
againsttransport.MultipartMixed
.General notes:
@StevenACoffman @giulio-opal