Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only bind to types in the root package scope #34

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Feb 26, 2018

This was causing findGoType to randomly bind to struct properties with the same name as a top level property.

eg:

type Foo struct {
   //...
}

type Bar struct {
   Foo string
}

Foo would sometimes find the struct Foo, but sometimes bind to property.

@vektah vektah merged commit e47d503 into master Feb 26, 2018
@vektah vektah deleted the root-types-only branch February 26, 2018 23:50
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Only bind to types in the root package scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant