-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal references to NewDefaultServer #3406
Merged
StevenACoffman
merged 13 commits into
99designs:deprecate_new_default_server
from
phughes-scwx:deprecate_new_default_server
Dec 5, 2024
Merged
Remove internal references to NewDefaultServer #3406
StevenACoffman
merged 13 commits into
99designs:deprecate_new_default_server
from
phughes-scwx:deprecate_new_default_server
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wow, thanks! That must have been a whole bottle of red! |
StevenACoffman
merged commit Dec 5, 2024
ca4954c
into
99designs:deprecate_new_default_server
16 of 17 checks passed
StevenACoffman
added a commit
that referenced
this pull request
Dec 5, 2024
* Deprecate NewDefaultServer Signed-off-by: Steve Coffman <steve@khanacademy.org> * Remove internal references to NewDefaultServer (#3406) * replace in init server template * update _examples * update plugin tests * grep default setup across testserver/singlefile with test helper * replace all other cases in testserver/singlefile * replace testserver/nullabledirectives * grep testserver/followschema with test helper; fix all other cases * replace all test helpers with code * lint * docs: introspection (big change) * docs: simple replacements in code examples * docs: overhaul of subscriptions * add introspection to federation example for js tests --------- Signed-off-by: Steve Coffman <steve@khanacademy.org> Co-authored-by: phughes-scwx <153771445+phughes-scwx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a pass that removes all references to NewDefaultServer, now deprecated, from three main places:
I have made a few personal choices, that may or may not fit with your expectations: