Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal references to NewDefaultServer #3406

Conversation

phughes-scwx
Copy link
Contributor

@phughes-scwx phughes-scwx commented Dec 4, 2024

Here is a pass that removes all references to NewDefaultServer, now deprecated, from three main places:

  1. tests that used it for fast and simple setup;
  2. the gqlgen init template for a basic server, and the examples based on that template;
  3. documentation.

I have made a few personal choices, that may or may not fit with your expectations:

  • I have removed the WebSocket and MultipartForm transports from the init template, since they introduce security issues to any server that uses them and should be opted-in to.
  • I have extended and changed the wording of some documentation, especially for Introspection and Subscriptions.

@coveralls
Copy link

coveralls commented Dec 4, 2024

Coverage Status

coverage: 59.722% (-0.1%) from 59.869%
when pulling 18967b9 on phughes-scwx:deprecate_new_default_server
into 154c19f on 99designs:deprecate_new_default_server.

@StevenACoffman
Copy link
Collaborator

Wow, thanks! That must have been a whole bottle of red!

@StevenACoffman StevenACoffman merged commit ca4954c into 99designs:deprecate_new_default_server Dec 5, 2024
16 of 17 checks passed
StevenACoffman added a commit that referenced this pull request Dec 5, 2024
* Deprecate NewDefaultServer

Signed-off-by: Steve Coffman <steve@khanacademy.org>

* Remove internal references to NewDefaultServer (#3406)

* replace in init server template

* update _examples

* update plugin tests

* grep default setup across testserver/singlefile with test helper

* replace all other cases in testserver/singlefile

* replace testserver/nullabledirectives

* grep testserver/followschema with test helper; fix all other cases

* replace all test helpers with code

* lint

* docs: introspection (big change)

* docs: simple replacements in code examples

* docs: overhaul of subscriptions

* add introspection to federation example for js tests

---------

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Co-authored-by: phughes-scwx <153771445+phughes-scwx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants