Parent middleware generated contexts #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any context generated by resolver middleware is only passed to the resolver, not to the children. This means tracing middleware like OpenTracing and OpenCensus cant correctly set the parent span info.
This is an alternative to #327 that uses the context that would be passed to the resolver, instead of returning one from the outer most middleware.
Advantages:
I haven't addressed setting context from resolvers, but it's more obvious that you cant manipulate the context from inside a resolver (no next func). If we need it we can add a
ChildContext
prop toResolverContext
with a method that lets the user change it.Thoughts @vvakame?
I have: