Don't let goimports guess import paths #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gqlgen internally tracks all the imports used in a file and adds them to the import block, handling duplicate imports by appending names.
There are two sources of imports:
ambientImports
: these are referenced in the templates and must keep the name they were given in the templates, egfmt.Println(
must get the import namefmt
. Often these are in conditional parts of the templates and may not be used in a particular generated output.Currently we run the generated code through
goimports
, this does a few things for us:This PR removes the "add missing imports" feature of goimports, while maintaining the other 3 by reimplementing the import removal logic and calling goimports with "Format only" to get grouping and sorting.
Fixes #207