Fix set header to JSON earlier in GraphQL response #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonna
force-pushed
the
fix-missing-json-content-type
branch
from
6d9f59d to
8d8cdd5
Compare
Update the GraphQL handler to set the Response Header to JSON earlier for error messages to be returned as JSON and not text/html. Fixes #519 == Notes: - Add checks for JSON Content-Type checks in decode bad queries tests
Sonna
force-pushed
the
fix-missing-json-content-type
branch
from
8d8cdd5 to
b4c5a07
Compare
vektah
approved these changes
Feb 5, 2019
|
Why do the CircleCI checks fail? |
Merged
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
…ent-type Fix set header to JSON earlier in GraphQL response Update the GraphQL handler to set the Response Header to JSON earlier for error messages to be returned as JSON and not text/html. Fixes 99designs#519 ## Notes: - Add checks for JSON Content-Type checks in decode bad queries tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the GraphQL handler to set the Response Header to JSON earlier for
error messages to be returned as JSON and not text/html.
Fixes #519
Notes: