Add more validation checks on .yml config file #542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two validation checks after parsing gqlgen.yml:
Although this may seem intuitive, but it can get tricky in a few cases.
For instance, the following gqlgen.yml config file:
When generating the code, the following error message shows up:
generating resolver failed: resolver build failed: required package was not loaded: github.com/elgarni/project/generated.User exit status 2
The message could be more descriptive. Moreover, the code was generated for exec.go and models.go, which will not compile anyways since they have different package names.
After this PR, the error message becomes:
And no code was generated.
The objective of this PR is to stop execution early on, if there are errors in the config file, and not generating any code unless everything is defined correctly in gqlgen.yml