-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix directives on fields with custom scalars #544
Conversation
Needs a test |
Added to the integration schema such that it will catch said bug during go generate. Prior to diff running go generate with the added schema:
After diff it builds fine. @vektah I'm hoping that would cover the "test" ask? If not, I would need some guidance on what would be a good example test to follow/improve. |
1d79b3e
to
0b0e4a9
Compare
…tion schema Added to the integration schema such that the build will catch the directive bug in question.
Not sure if the failure is from me force pushing or something else as it just works local. |
Yeah, that looks good. As long as it cant happen again without something breaking. Most of the templates are covered like this.
Its failing because you've changed the testserver schema but havent run |
I see, looks like theres some instability in the generated code. It looks unrelated to this change so Ill fix it on next. |
Fix directives on fields with custom scalars
The bug occurs when using a custom defined scalar, an input type, and directive together.
E.g.
would generate:
now: