Only Inject Builtin Scalars if Defined in Schema #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewbyrne
force-pushed
the
fix-inject-builtin-scalars
branch
from
ae14198 to
d10e048
Compare
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
…alars Only Inject Builtin Scalars if Defined in Schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629
There was an issue where defining
Time(andMap) in the schema as object types caused a panic. This was due toInjectBuiltinsattempting to inject a scalar type into theTypeMap. This updates the injection to only happen if the scalar types are defined.Worth noting that
InjectBuiltinsis called twice, once in modelgen and again inBuildDatashortly after. May be worth fixing this so that there is only a single call.I have: