Better CollectFields performance #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was done because RequestContext is a part of executionContext and can be passed directly without extraction from ctx. This is increasing performance when model depth is high
|
Came into this pretty cynical, but it looks pretty straight forward. Nice! My last round of perf digging - #465. I think the next big wins are in eliminating as many goroutines as possible during execution, probably by shipping a dataloader solution integrated with gqlgen that doesnt require goroutines and forcing users to be more explicit around which resolvers need to be concurrent. Going to require a bit of planning. |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Better CollectFields performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectFields was increased thanks to following improvements:
Before
BenchmarkSimpleQueryNoArgs-4 100000 20736 ns/op 6628 B/op 120 allocs/opAfter
BenchmarkSimpleQueryNoArgs-4 100000 19513 ns/op 6692 B/op 120 allocs/opIn practice, difference is much bigger on complex models