Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: omit deprecated fields when includeDeprecated=false #687

Merged
merged 1 commit into from
May 1, 2019
Merged

Fix: omit deprecated fields when includeDeprecated=false #687

merged 1 commit into from
May 1, 2019

Conversation

stereosteve
Copy link
Contributor

Introspection with includeDeprecated=false would still return deprecated fields. In practice this is a small deal because the introspection query typically has includeDeprecated=true.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah merged commit d1e8acd into 99designs:master May 1, 2019
@vektah
Copy link
Collaborator

vektah commented May 1, 2019

Nice, thanks!

@vektah vektah added the v0.9 Fixed in 0.9.0 label May 15, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#687 from stereosteve/fix-includeDeprecated
0138464 
Fix: omit deprecated fields when includeDeprecated=false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.9 Fixed in 0.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stereosteve @vektah