Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataloaders.md #758

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Update dataloaders.md #758

merged 1 commit into from
Jun 26, 2019

Conversation

franxois
Copy link
Contributor

I may have seen a mistake in documentation with dataloader. I update code to make SQL request use requested IDs.

I use a map to store result by IDs, then I recreate output array to return values

fix #757

Make SQL request use requested IDs
@vektah
Copy link
Collaborator

vektah commented Jun 26, 2019

👍 this probably serves a better base to start working from.

@vektah vektah merged commit 2dc8423 into 99designs:master Jun 26, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataloader code exemple may be wrong
2 participants