Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send keepalive on init #820

Merged
merged 1 commit into from
Aug 8, 2019
Merged

send keepalive on init #820

merged 1 commit into from
Aug 8, 2019

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Aug 8, 2019

fixes #745
replaces #809

tested against apollo client via the chat app:
image

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah requested a review from sinamt August 8, 2019 01:12
@vektah vektah merged commit 2599f56 into master Aug 8, 2019
@vektah vektah deleted the keepalive-on-init branch August 8, 2019 01:26
@vektah vektah added the v0.9.2 label Aug 8, 2019
@JulienBreux
Copy link

🎉 Thanks @vektah

cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep alive message does not follow the Ack message
3 participants