deduplicate package load between AutoBind and Binder #945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the optimizations suggested in #918.
Improvements against master:
Before:
After:
"build time" is the time spent in the build phase of api/generate.go. The first set of loads is part of the models plugin and the second is part of the core functionality.
Note that this reorders InjectBuiltins and AutoBind. I'm not sure what the consequences of that are.
I'm surprised that tests didn't break without 8c110b7 but generation in our private repo did. I don't fully understand this code yet. I'd appreciate tips for adding a test for it.
I have: