Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always return OperationContext for postpone process #947

Merged
merged 1 commit into from
Nov 28, 2019
Merged

always return OperationContext for postpone process #947

merged 1 commit into from
Nov 28, 2019

Conversation

vvakame
Copy link
Collaborator

@vvakame vvakame commented Nov 28, 2019 •
edited
Loading

refs #885
suppress runtime error: invalid memory address or nil pointer dereference in ApolloTracing

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vvakame vvakame requested a review from vektah November 28, 2019 07:26
@vvakame vvakame force-pushed the handler-oc-handling branch from 275f6fe to 922db1e Compare November 28, 2019 07:43
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 63.818% when pulling 922db1e on handler-oc-handling into 14dbf1a on handler-refactor.

@vvakame vvakame mentioned this pull request Nov 28, 2019
Merged
10 tasks
@vektah vektah merged commit 5106480 into handler-refactor Nov 28, 2019
@vektah vektah deleted the handler-oc-handling branch November 28, 2019 11:15
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#947 from 99designs/handler-oc-handling
e97b7bd 
always return OperationContext for postpone process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vektah vektah Awaiting requested review from vektah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvakame @coveralls @vektah