Allow customizing http and websocket status codes for errors #978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a general rule that:
same applies to websockets, except they use GQL_ERROR and GQL_DATA message types instead of status codes.
But we need a way to distinguish between the types of errors. Apollo sets a "code" extension, lets copy them and match their codes. I've included the two core ones in the
errcode
package, you can return anything and they will be treated as 200s by default. To register a custom 422:I've also added integration tests for websockets and fixes a bunch of websocket related issues, mostly around error handling.
closes #948
closes #965
I have: