New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UrlBuilder to work better with PHP clone operator #26

Merged

dhotson merged 1 commit into master from cloneable-url-builder

Jan 23, 2017

Contributor

dhotson commented Jan 23, 2017

Being able to clone the url builder instance can be useful in certain situations. e.g.

$builder = Thumbor\Url\Builder::construct($server, $secret, 'http://a.com/b.jpg');

$a = clone $builder;
$a->addFilter('fill', 'green');

$b = clone $builder;
$b->addFilter('fill', 'red');

This PR makes this possible by ensuring the $commands instance variable is also cloned correctly.


          Fixes \Thumbor\Url\Builder to work better with clone operator

dhotson merged commit 7b32a4b into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet