Removed insecure dependency . #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rehrumesh
reviewed
Feb 21, 2019
| @@ -14,7 +14,7 @@ var absPath = function (p) { | |||
|
|
|||
| var removeDir = function (relPath, callback) { | |||
| var path = absPath(relPath); | |||
| rmdir(path, callback); | |||
| exec('rm -r ' + path, callback); | |||
There was a problem hiding this comment.
Just wanted to check if this will work in Windows.
There was a problem hiding this comment.
@rehrumesh thanks for this question. It almost certainly does not work on Windows and I have no way to test it anyways. Do you have any ideas for how to address this?
There was a problem hiding this comment.
Take a look at this gist I found today: https://gist.github.com/laazebislam/845e61a18541255c0a29eeeb4e0141f4
It looks like it would work and remove a dependency.
|
This can be closed now as #40 is merged! |
|
Please close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue: #38