fix: update installer to use https for download

[eheyder]

fix error with 403 on http://s3-us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_latest.tar.gz

[sethalt]

Thanks!

[jnorris-rbi]

LGTM, thanks for tackling this change!

[pablogdnd]

LGTM

[jphechter]

Please add this.

[pablogdnd]

@AshanFernando can you check at this?

[DeeWBee]

@AshanFernando several projects are now falling apart. Please fix this.

[yaguchii]

merge please

[kairi4]

@rehrumesh @mjzone
Please review and merge this PR if possible

[huseyin-caglayan-cko]

    http = require('http'),
    https = require('https'),

[huseyin-caglayan-cko]

keeps support for http as well as https

[huseyin-caglayan-cko]

    const client = downloadUrl.toLowerCase().startsWith('https') ? https : http;
    client
        .get(downloadUrl, function (response) {

[JonatanPotrikus]

Good idea @huseyin-caglayan-cko

[vestel]

Looks good! Please approve!

[LeoFalco]

merge please

[willaug]

merge, please?

[DeeWBee]

Circling back here: I ditched this package (along with severless-dynamodb-local) and resorted to using Docker + DynamoDB. I modified the docker-compose file to use my desired port but otherwise kept the default configuration in place (as provided by AWS).

From there, I manually created needed tables inside the Docker image. To create tables in the Docker image, you append --endpoint-url http://localhost:[YOUR_PORT_HERE] to the regular create table command. From there, I was able to start my app using sls offline start. It's clear the author of these packages won't be updating anytime soon. I suggest people implement similar solutions and move off this expired package.

I'll update this comment once the problematic packages have been completely removed from my app.

UPDATE: I removed the problematic packages from my app, and everything still works. I am officially done using these. Like I said, I suggest people do the same.

[jlau-neonone]

This fix worked for me.

[jlau-neonone]

This worked for me.

[Viserion77]

I joined node_modules and edit directly the dynamodb-localhost files with the changes of this PR and it worked!

[DeeWBee]

For those of you directly editing node_modules - please understand the next time you run npm install or clear your cache (or any equivalent commands), you will overwrite your edits and it will be broken again. Please consider using different solutions.

[sachet-mittal]

@DeeWBee I think the solution you are suggesting is a very complicated workaround and adding a new infra (docker) in project which may not be possible for all the projects. The "correct" fix is to patch the node_modules using https://github.com/ds300/patch-package.

note: I say this is correct as this would work on local/docker/CI-CD environments with minimal changes but YMMV. If docker works for you then please continue doing that as you already tackled the most difficult part and made your project more robust.

[gpmcadam]

thanks for merging. any idea when this will be published to npm?

[McKean]

if anyone needs this to work in your containers (for testing) until the package is updated, just throw those lines into your Dockerfile after installing your packages (npm install or yarn)

# until package is updated
RUN sed -i 's|http://s3-us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_latest.tar.gz|https://s3.us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_latest.tar.gz|g' node_modules/dynamodb-localhost/dynamodb/config.json
RUN sed -i 's|http|https|g' node_modules/dynamodb-localhost/dynamodb/installer.js

[jonnixt17]

Or npm install --save 99x/dynamodb-localhost#db30898f8c40932c7177be7b2f1a81360d12876d should work while we wait. (Do keep in mind there was at least one additional merge done between the last npm release and the current master.)

[LeoFalco]

Helllo, @AshanFernando

Can you publish this fix on npm too ?

[LeoFalco]

Helllo, @AshanFernando

Can you publish this fix on npm too ?

I wish a new released version to bump dependency of dynamodb-localhost lib on package serverless-dynamodb-local

[codebravotech]

Please merge!

[voccer]

the PR was merged, but it is still an old version in the npm package.

[colesiegel]

This still doesn't work - was it released?

@AshanFernando

[tspangler]

looks like this needs a new npm release

[domdomegg]

FYI: Despite this PR being merged, this fix to the package (dynamodb-localhost) still hasn't been published, with no new releases to NPM in over 4 years.

Solution: You can use aws-dynamodb-local, a maintained fork, instead. (Disclaimer: I am a contributor to this fork). It is a drop-in replacement for this package, and is updated to fix this bug. If you're using serverless-dynamodb-local, you can also replace that with it's equivalent serverless-dynamodb.

Migrating takes about 2 minutes, with a full guide in the README. Of course, it's all still open-source and MIT licensed. Ownership of this new package sits with a registered charity, that is committed to maintaining the package into the future and is open to contributions from the community.